Skip to content

Hafs moving nest grid debug test#1592

Closed
junwang-noaa wants to merge 9 commits into
ufs-community:developfrom
junwang-noaa:hafs_movingnest_debug
Closed

Hafs moving nest grid debug test#1592
junwang-noaa wants to merge 9 commits into
ufs-community:developfrom
junwang-noaa:hafs_movingnest_debug

Conversation

@junwang-noaa
Copy link
Copy Markdown
Collaborator

@junwang-noaa junwang-noaa commented Jan 31, 2023

Description

This PR fixes the issue with the initialization of the moving nest output grid on write grid component.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
  • a new test is added: hafs_regional_storm_following_1nest_atm_ocn_debug

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE6
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Depends on: NOAA-EMC/ufsatm#622
Closes #1588

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@junwang-noaa
Copy link
Copy Markdown
Collaborator Author

@junwang-noaa junwang-noaa changed the title Hafs movingnest debug Hafs moving nest grid debug test Jan 31, 2023
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

@junwang-noaa We're only missing ORT results for the new test and to verify that you have run the full RT suite somewhere.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA The test being added is actually an ORT itself.

@BinLiu-NOAA
Copy link
Copy Markdown
Contributor

@junwang-noaa, Thanks for quickly fixing this issue! The code/script changes and the added HAFS debug test look good to me. @BijuThomas-NOAA, could you please help to conduct a test from your end to confirm the debug build can now work fine for the HAFS moving-nesting configuration with the regional_latlon_moving output grid option? Thanks!

@BijuThomas-NOAA
Copy link
Copy Markdown
Contributor

@junwang-noaa Thanks for the fix! I tested debug build with regional_storm_following_1nest_atm_ocn_debug (output_grid: regional_latlon) on Orion and the test was completed successfully

Copy link
Copy Markdown
Contributor

@BinLiu-NOAA BinLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly fixing this! The code/script changes and the added HAFS debug test look good to me.

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Feb 9, 2023

@junwang-noaa can you sync up? @jiandewang will pick up from there.

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Feb 9, 2023

@jiandewang is quick. BTW, @junwang-noaa can you create a direct pr to https://github.com/jiandewang/ufs-weather-model/tree/feature/update-MOM6-20230206 ? I think that's a quickest way to combine the PRs.

@jiandewang
Copy link
Copy Markdown
Collaborator

@jiandewang is quick. BTW, @junwang-noaa can you create a direct pr to https://github.com/jiandewang/ufs-weather-model/tree/feature/update-MOM6-20230206 ? I think that's a quickest way to combine the PRs.

just merged, Jun works as fast as lighting, same for me. Now we have a clean PR

@jkbk2004
Copy link
Copy Markdown
Collaborator

merged with #1606

@jkbk2004 jkbk2004 closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hafs_regional_storm_following_1nest_atm_ocn failed with debug test

7 participants