Bug fix for cloud effective radius for convective clouds (HR1)

[ChunxiZhang-NOAA]

Description

This is an emergency bug fix for cloud effective radius for convective clouds in ccpp-physics (Issuehttps://github.com/ufs-community/ccpp-physics/issues/36).

Input data additions/changes

• No changes are expected to input data.
• There will be new input data.
• Input data will be updated.

Anticipated changes to regression tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

All cpld and control_p8 related PRs failed as expected.
RegressionTests_hera.intel.log

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Combined with PR's (If Applicable):

Commit Queue Checklist:

• Link PR's from all sub-components involved
• Confirm reviews completed in sub-component PR's
• Add all appropriate labels to this PR.
• Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
• Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Dependencies:

• Depends on Bug fix for cloud effective radius for convective clouds (HR1) ccpp-physics#35
• Depends on Bug fix for cloud effective radius for convective clouds (HR1) NOAA-EMC/ufsatm#621

Issue:

• The cloud effective radii for convective clouds are not correctly assigned ccpp-physics#36

Testing Day Checklist:

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

• RDHPCS
  • Intel
    • Hera
    • Orion
    • Jet
    • Gaea
    • Cheyenne
  • GNU
    • Hera
    • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[jkbk2004]

With an urgency of this pr, I will start testing while we collect the reviews. @ChunxiZhang-NOAA I am adding new BL_DATE.

[BrianCurtis-NOAA]

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: BL
Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1217200031/20230126114209/ufs-weather-model
Please manually delete: /glade/scratch/epicufsrt/FV3_RT/rt_60961
Test hafs_regional_atm_ocn 082 failed in run_test failed
Test hafs_regional_atm_wav 083 failed in run_test failed
Test hafs_regional_atm_ocn_wav 084 failed in run_test failed
Test hafs_regional_1nest_atm 085 failed in run_test failed
Test hafs_regional_telescopic_2nests_atm 086 failed in run_test failed
Test hafs_global_multiple_4nests_atm 088 failed in run_test failed
Test hafs_regional_storm_following_1nest_atm_ocn 091 failed in run_test failed
Test hafs_regional_docn 094 failed in run_test failed
Test hafs_regional_docn_oisst 095 failed in run_test failed
Test hafs_regional_datm_cdeps 096 failed in run_test failed
Test control_p8_atmlnd_sbs 110 failed in run_test failed
Test atmaero_control_p8 112 failed in run_test failed
Test atmaero_control_p8_rad 113 failed in run_test failed
Test atmaero_control_p8_rad_micro 114 failed in run_test failed
Test regional_atmaq 115 failed in run_test failed
Test regional_atmaq_debug 116 failed in run_test failed
Test compile_019 failed in run_compile failed
Please make changes and add the following label back: cheyenne-intel-BL

[jkbk2004]

@ChunxiZhang-NOAA ORT issue was from #1523 We need to update ORT script. @zach1221 is going to create issue. And hopefully we can keep moving with the pr.

[BrianCurtis-NOAA]

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: RT
[RT] Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1217200031/20230126154209/ufs-weather-model
Please make changes and add the following label back: cheyenne-intel-RT

[jkbk2004]

sounds like there is epicufsrt diskquota issue on cheyenne

[zach1221]

ORT issue opened here #1586

[BrianCurtis-NOAA]

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: RT
[RT] Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1217200031/20230126175717/ufs-weather-model
[RT] Error: Test regional_atmaq_debug 151 failed in run_test failed
Please make changes and add the following label back: cheyenne-intel-RT

[jkbk2004]

@BrianCurtis-NOAA @SadeghTabas-NOAA RDHPCS tests are done. ORT issue should be addressed in separate PR. This PR can move on for merging after wcoss2 tests.

[BrianCurtis-NOAA]

I haven't had a chance to run on WCOSS2. It's not available today until maybe 3PM. If that's too late, let me know.

[jkbk2004]

@ChunxiZhang-NOAA if ok, we can plan to merge by Monday morning ?

[ChunxiZhang-NOAA]

@jkbk2004 I can merge it in early Monday afternoon.

[BrianCurtis-NOAA]

Dogwood just opened up. Starting RT.

[jkbk2004]

Dogwood just opened up. Starting RT.

Cool!

[BrianCurtis-NOAA]

Since everything looks OK this morning, I'll start the upstream merge process.

[jkbk2004]

Since everything looks OK this morning, I'll start the upstream merge process.

@BrianCurtis-NOAA Thanks!

[jkbk2004]

@BrianCurtis-NOAA the fv3atm pr was merged.