Skip to content

update CMEPS#1570

Merged
jkbk2004 merged 17 commits into
ufs-community:developfrom
DeniseWorthen:feature/updcmeps
Feb 1, 2023
Merged

update CMEPS#1570
jkbk2004 merged 17 commits into
ufs-community:developfrom
DeniseWorthen:feature/updcmeps

Conversation

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen commented Jan 18, 2023

Description

Updates CMEPS to latest ESCOMP/main; removes references to 'master', removes unused variables, fixes issue of incorrect units in mediator output files when mesh or grid is in radians and not degrees

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test. All hera.intel and hera.gnu baselines are B4B at c5d202b
  • Changes are expected to the following tests:

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Issues Addressed:

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@zach1221
Copy link
Copy Markdown
Collaborator

Hello, @DeniseWorthen and @BrianCurtis-NOAA
Are we ready to start requesting reviews and adding RT labels to this PR?

@jkbk2004
Copy link
Copy Markdown
Collaborator

FYI, #1529 was delayed. We can start working on this PR.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

DeniseWorthen commented Jan 30, 2023

We should have reviews on CMEPS PR before starting.

Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No UFSWM code to review. Approved for testing.

@jkbk2004 jkbk2004 added Waiting for Reviews The PR is waiting for reviews from associated component PR's. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Jan 30, 2023
on-behalf-of @ufs-community <jong.kim@noaa.gov>
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

@jkbk2004 Is the EPIC github bot going to be used for the pushes and label updates?

@zach1221
Copy link
Copy Markdown
Collaborator

Hi, @BrianCurtis-NOAA. I think I can speak to your question. Right now the CI team is working to create a new email address for the NOAA EPIC service account. Then your name/account can be replaced with the service account.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Hi, @BrianCurtis-NOAA. I think I can speak to your question. Right now the CI team is working to create a new email address for the NOAA EPIC service account. Then your name/account can be replaced with the service account.

Awesome, thanks for the update.

on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: orion
Compiler: intel
Job: RT
[RT] Repo location: /work/noaa/nems/emc.nemspara/autort/pr/1201713042/20230130143025/ufs-weather-model
Please make changes and add the following label back: orion-intel-RT

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: hera
Compiler: gnu
Job: RT
[RT] Repo location: /scratch1/NCEPDEV/nems/emc.nemspara/autort/pr/1201713042/20230130201511/ufs-weather-model
[RT] Error: Test cpld_control_p8 046 failed in run_test failed
Please make changes and add the following label back: hera-gnu-RT

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

The hera.gnu cpld_control_p8 timed out.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

Automated RT Failure Notification
Machine: cheyenne
Compiler: intel
Job: RT
[RT] Repo location: /glade/scratch/epicufsrt/autort/jenkins/autort/pr/1201713042/20230130125710/ufs-weather-model
[RT] Error: Test regional_atmaq_debug 151 failed in run_test failed
Please make changes and add the following label back: cheyenne-intel-RT

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

The cheyenne.intel regional_atmaq_debug timed out.

@jkbk2004
Copy link
Copy Markdown
Collaborator

Sounds like Orion has system issue today.

@jkbk2004
Copy link
Copy Markdown
Collaborator

The cheyenne.intel regional_atmaq_debug timed out.

The cheyenne.intel regional_atmaq_debug timed out.

I like to trun off regional_atmaq_debug since the time-out issue continues. @BrianCurtis-NOAA FYI

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

I like to trun off regional_atmaq_debug since the time-out issue continues. @BrianCurtis-NOAA FYI

Thats OK, the upcoming AQM PR will be disabling it anyways.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

the coupler files are having a weird time on Acorn comparing, but using nccmp they are identical, so something weird is going on. I usually am OK if WCOSS2 or Acorn pass, but with Cactus having issues, and Acorn as well its different. Let's not delay this any more. I'll work on it early tomorrow morning in hopes to have one pass before merge.

@jkbk2004 jkbk2004 merged commit 130f857 into ufs-community:develop Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Waiting for Reviews The PR is waiting for reviews from associated component PR's.

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

4 participants