Skip to content

Bring in calculations for point source emissions in AQM#1560

Merged
jkbk2004 merged 30 commits into
ufs-community:developfrom
BrianCurtis-NOAA:feature/point-source
Jan 9, 2023
Merged

Bring in calculations for point source emissions in AQM#1560
jkbk2004 merged 30 commits into
ufs-community:developfrom
BrianCurtis-NOAA:feature/point-source

Conversation

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA commented Jan 6, 2023

Description

This PR brings in a capability to the AQM to add point source emissions to air quality calculations.

Top of commit queue on: TBD

Input data additions/changes

  • No changes are expected to input data.
  • There will be new input data.
  • Input data will be updated.

Anticipated changes to regression tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:

Test regional_atmaq 152 failed in check_result failed
Test regional_atmaq_debug 153 failed in check_result failed

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Combined with PR's (If Applicable):

Commit Queue Checklist:

  • Link PR's from all sub-components involved
  • Confirm reviews completed in sub-component PR's
  • Add all appropriate labels to this PR.
  • Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
  • Add list of any failed regression tests to "Anticipated changes to regression tests" section.

Linked PR's and Issues:

Depends on NOAA-EMC/ufsatm#616
Depends on NOAA-EMC/AQM#53

Testing Day Checklist:

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

Testing Log (for CM's):

  • RDHPCS
    • Intel
      • Hera
      • Orion
      • Jet
      • Gaea
      • Cheyenne
    • GNU
      • Hera
      • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BrianCurtis-NOAA BrianCurtis-NOAA added Baseline Updates Current baselines will be updated. input data change Changes Existing Input Data Existing input data will be changed. A new input-data-YYYYMMDD directory must be created. and removed input data change labels Jan 6, 2023
@BrianCurtis-NOAA BrianCurtis-NOAA marked this pull request as ready for review January 6, 2023 16:03
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator Author

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: BL
[BL] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1188307026/20230107004518/ufs-weather-model
[BL] Error: Test control_c384 018 failed in run_test failed
Please make changes and add the following label back: jet-intel-BL

@jkbk2004
Copy link
Copy Markdown
Collaborator

jkbk2004 commented Jan 9, 2023

All tests are done. we can start merging process. can we get final review/

@jkbk2004 jkbk2004 self-requested a review January 9, 2023 21:05
@jkbk2004 jkbk2004 merged commit e50f701 into ufs-community:develop Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. Changes Existing Input Data Existing input data will be changed. A new input-data-YYYYMMDD directory must be created.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants