clean up gitaction yml#1552
Merged
Merged
Conversation
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
Collaborator
Author
|
@BrianCurtis-NOAA @zach1221 I created this pr to fix the issue of gitaction failures. The issue seems to be originated somewhere from pre job step in aux.yml. Once pre runs ok, it will create id_file w/o problem. I tested ok the cleanup of aux.yml with my personal git setup. No impact on other tests at all. so we can try to merge in tomorrow as a hot fix. |
Collaborator
Author
|
The key point is to clean up some of outdated lines like deleting run-ci labels in aux.yml |
zach1221
approved these changes
Jan 2, 2023
BrianCurtis-NOAA
requested changes
Jan 3, 2023
Collaborator
BrianCurtis-NOAA
left a comment
There was a problem hiding this comment.
@jkbk2004 Is the github repo check only checking fv3 submodule now? If so, we want to check all sub component repos. Maybe this is being worked on though?
Also I don't see a reason to overwrite the previous UFS RT logs. Please remove those.
BrianCurtis-NOAA
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Top of commit queue on: TBD
Input data additions/changes
Anticipated changes to regression tests:
Subcomponents involved:
Combined with PR's (If Applicable):
Commit Queue Checklist:
Linked PR's and Issues:
Testing Day Checklist:
Testing Log (for CM's):