Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
45e2f84
Update .gitmodules
DusanJovic-NOAA Dec 13, 2022
f404a1c
Update FV3
DusanJovic-NOAA Dec 13, 2022
89e9c02
Update PR Template
BrianCurtis-NOAA Dec 16, 2022
f671576
allow option no updated sub-components
BrianCurtis-NOAA Dec 16, 2022
fc49b6e
Comment bug/feature templates
BrianCurtis-NOAA Dec 16, 2022
4346a6f
Merge branch 'comment_templates' of github.com:BrianCurtis-NOAA/ufs-w…
BrianCurtis-NOAA Dec 16, 2022
56fbad9
Bring in @DeniseWorthen changes plus some.
BrianCurtis-NOAA Dec 19, 2022
9f76461
Update FV3
DusanJovic-NOAA Dec 27, 2022
7fa493a
Merge remote-tracking branch 'origin/develop' into time_unlimited
DusanJovic-NOAA Dec 27, 2022
7dfa04c
Merge remote-tracking branch 'brian/comment_templates' into time_unli…
DusanJovic-NOAA Dec 27, 2022
47c5a92
[AutoRT] hera.intel Job Completed.
BrianCurtis-NOAA Dec 27, 2022
8e2862b
Acorn Intel RT Log
BrianCurtis-NOAA Dec 27, 2022
bbb6c1d
WCOSS2 Intel RT Log
BrianCurtis-NOAA Dec 27, 2022
8782e50
[AutoRT] orion.intel Job Completed.
BrianCurtis-NOAA Dec 27, 2022
d997899
[AutoRT] jet.intel Job Completed.
BrianCurtis-NOAA Dec 27, 2022
03a015b
Run control_c384 and control_c384gdas tests on Gaea using TPN=18
DusanJovic-NOAA Dec 28, 2022
b2c4700
setting control_c384 and control_c384gdas with TPN=18 on cheyenne
jkbk2004 Dec 28, 2022
f1e1842
add cheyenne intel.gnu RT logs: passed
jkbk2004 Dec 28, 2022
614d7d1
add hera.gnu RT log: passed
jkbk2004 Dec 28, 2022
969ec2e
Revert .gitmodules and update FV3
DusanJovic-NOAA Dec 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,33 @@ assignees: ''
---

## Description
<!--
Provide a clear and concise description of what the bug is.
Also give a description of what behavior you expected to happen.
-->


### To Reproduce:
<!--
What compilers/machines are you seeing this with?
Give explicit steps to reproduce the behavior.
1. do this
2. then that
3. then, oops, look at the bug
-->


## Additional context
<!--
Add any other context about the problem here.
Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:
- needs to be fixed also in noaa-emc/nems/issues/<issue_number>
- needed for noaa-emc/fv3atm/pull/<pr_number>
-->


## Output

<!--
**Screenshots**
If applicable, drag and drop screenshots to help explain your problem.

Expand All @@ -37,5 +43,6 @@ If applicable, include relevant output logs.
Either drag and drop the entire log file here (if a long log) or

```
paste the code here (if a short section of log)
paste the code in this type of section (if a short section of log)
```
-->
9 changes: 8 additions & 1 deletion .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,22 @@ assignees: ''
---

## Description
<!--
Provide a clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
-->

## Solution
<!--
Add a clear and concise description of what you want to happen.
-->

## Alternatives
<!--
If applicable, add a description of any alternative solutions or features you've considered.
-->

## Related to
Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:
<!--Directly reference any issues or PRs in this or other repositories that this is related to, and describe how they are related. Example:
- required to support noaa-emc/nems/issues/<issue_number>
- needed by noaa-emc/fv3atm/pull/<pr_number>
-->
128 changes: 78 additions & 50 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,52 +1,80 @@
# PR Checklist

- [ ] This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model [wiki](https://github.com/ufs-community/ufs-weather-model/wiki/Making-code-changes-in-the-UFS-weather-model-and-its-subcomponents) if you are unsure how to do this.

- [ ] This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

- [ ] An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.

- [ ] Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

- [ ] New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

## Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.

## Description

<!--
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

### Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
- fixes #<issue_number>
- fixes noaa-emc/fv3atm/issues/<issue_number>

## Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

- [ ] hera.intel
- [ ] hera.gnu
- [ ] orion.intel
- [ ] cheyenne.intel
- [ ] cheyenne.gnu
- [ ] gaea.intel
- [ ] jet.intel
- [ ] wcoss2.intel
- [ ] acorn.intel
- [ ] opnReqTest for newly added/changed feature
- [ ] CI

## Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
- waiting on noaa-emc/nems/pull/<pr_number>
- waiting on noaa-emc/fv3atm/pull/<pr_number>
-->

### Top of commit queue on: TBD
<!-- Please have sub-component Code Managers ready for merging sub-component PR's on the date above and the day after the date above -->

### Input data additions/changes
- [ ] No changes are expected to input data.
- [ ] There will be new input data. <!-- Add "input data change" Label -->
- [ ] Input data will be updated. <!-- Add "New Input Data Req'd" Label -->

### Anticipated changes to regression tests:
- [ ] No changes are expected to any regression test. <!-- Add "No Baseline Change" Label -->
- [ ] Changes are expected to the following tests: <!-- Add "Baseline Change" Label -->
<!-- Please insert what RT's change and why you expect them to change -->

## Subcomponents involved:
- [ ] AQM
- [ ] CDEPS
- [ ] CICE
- [ ] CMEPS
- [ ] CMakeModules
- [ ] FV3
- [ ] GOCART
- [ ] HYCOM
- [ ] MOM6
- [ ] NOAHMP
- [ ] WW3
- [ ] stochastic_physics
- [ ] none

### Combined with PR's (If Applicable):

## Commit Queue Checklist:
<!--
Please complete all items in list. Make sure to attach logs from RT testing in comment, not in repository. Once all boxes are checked, please add the label "Ready for Commit Queue".
-->
- [ ] Link PR's from all sub-components involved
- [ ] Confirm reviews completed in sub-component PR's
- [ ] Add all appropriate labels to this PR.
- [ ] Run full RT suite on either Hera/Cheyenne with both Intel/GNU compilers
- [ ] Add list of any failed regression tests to "Anticipated changes to regression tests" section.

## Linked PR's and Issues:
<!--
Please link dependent pull requests.
EXAMPLE: Depends on NOAA-EMC/fv3atm/pull/<pullrequest_number>

Please link the related issues to be closed with this PR, whether in this repository, or in another repository.
EXAMPLE: Closes NOAA-EMC/fv3atm/issues/<issue_number>
-->

## Testing Day Checklist:
<!--
Please consult the ufs-weather-model [wiki](https://github.com/ufs-community/ufs-weather-model/wiki/Making-code-changes-in-the-UFS-weather-model-and-its-subcomponents) if you are unsure how to do this.
-->
- [ ] This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
- [ ] Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.

### Testing Log (for CM's):
- RDHPCS
- Intel
- [ ] Hera
- [ ] Orion
- [ ] Jet
- [ ] Gaea
- [ ] Cheyenne
- GNU
- [ ] Hera
- [ ] Cheyenne
- WCOSS2
- [ ] Dogwood/Cactus
- [ ] Acorn
- CI
- [ ] Completed
- opnReqTest
- [ ] N/A
- [ ] Log attached to comment
2 changes: 1 addition & 1 deletion FV3
Submodule FV3 updated from a45e1b to b877da
Loading