Skip to content

Jet build config update, Hera GNU support, FV3 dycore GNU bugfix#151

Merged
DusanJovic-NOAA merged 10 commits into
ufs-community:developfrom
climbfuji:jetbuild-heragnu-dycore-update
Jun 22, 2020
Merged

Jet build config update, Hera GNU support, FV3 dycore GNU bugfix#151
DusanJovic-NOAA merged 10 commits into
ufs-community:developfrom
climbfuji:jetbuild-heragnu-dycore-update

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Jun 19, 2020 •
edited
Loading

This PR contains

  • an update to fix GNU compiler issues for the FV3 dycore (GFDL_atmos_cubed_sphere)
  • support for using the GNU compiler on Hera (Update modulefile for hera.gnu Update modulefile for hera.gnu #147)
  • an update of build.sh from branch release/public-v1
  • an update/bugfix for the Jet build config to pass the correct SIMD flags to CCPP

Associated PRs:
https://github.com/ufs-community/ufs-weather-model/pull/151/files
NOAA-EMC/ufsatm#131
NOAA-EMC/GFDL_atmos_cubed_sphere#22

For regression testing information, see below NOT YET.

@climbfuji climbfuji marked this pull request as ready for review June 19, 2020 20:11
@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jun 19, 2020

This code compiles on macOS with gcc+gfortran and clang+gfortran, with Python 2.7 and 3.7.

@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jun 19, 2020

@junwang-noaa @DusanJovic-NOAA do you want to enable hera.gnu as tier-1 platform with this PR? If so, please rsync /scratch1/NCEPDEV/stmp4/Dom.Heinzeller/FV3_RT/REGRESSION_TEST_GNU/ to /scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/develop-20200611/GNU/

Please let me know. Thanks!

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

DusanJovic-NOAA commented Jun 19, 2020

@junwang-noaa @DusanJovic-NOAA do you want to enable hera.gnu as tier-1 platform with this PR? If so, please rsync /scratch1/NCEPDEV/stmp4/Dom.Heinzeller/FV3_RT/REGRESSION_TEST_GNU/ to /scratch1/NCEPDEV/nems/emc.nemspara/RT/NEMSfv3gfs/develop-20200611/GNU/

Please let me know. Thanks!

Yes.

Synced to develop-20200611/GNU

@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jun 19, 2020

Regression testing on hera.intel using rt.conf: all tests pass, regression test logs updated in the PR.

rt_hera_intel.log

@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jun 19, 2020

Regression testing on hera.intel using rt_gnu.conf: all tests pass, regression test logs updated in the PR.

rt_hera_gnu_create.log
rt_hera_gnu_verify.log

@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jun 19, 2020

Regression testing on orion.intel, wcoss_cray and wcoss_dell_p3 all pass. Regression test logs updated in the PR.

@climbfuji climbfuji mentioned this pull request Jun 19, 2020
Closed
@DusanJovic-NOAA DusanJovic-NOAA merged commit 4edc6cf into ufs-community:develop Jun 22, 2020
@climbfuji climbfuji mentioned this pull request Jun 29, 2020
Closed
pjpegion pushed a commit to NOAA-PSL/ufs-weather-model.p7b that referenced this pull request Jul 20, 2021
@dustinswales @climbfuji
RRTMGP improvements (ufs-community#151)
1959bde 
* Add infrastructure to FV3 for recent RRTMGP improvements in ccpp-physics
* Move allocate statements
* Updated ccpp-physics
* Updated physics. Some changes on FV3 side to handle physics changes.
* Updated .gitmodules
* Revert change to .gitmodules and update submodule pointer for ccpp-physics
Co-authored-by: Dom Heinzeller <climbfuji@ymail.com>
SamuelTrahanNOAA added a commit to SamuelTrahanNOAA/ufs-weather-model that referenced this pull request Oct 13, 2022
@hu5970 @SamuelTrahanNOAA
updates for RRFS baseline E (ufs-community#151)
78a721c 
* Add code from EmC (Jun Wang) for fast read restart files.
Add code from Tanya.

* Point to hu5970 for fv3atm

* Update subnmodel FV3.

* remove FV3GFS_io_netcdf

* hera gnu tests passed

* hera.intel tests passed

* jet intel tests passed

* point to gsl submodules

* update bl_date and revert local changes to rt.sh

Co-authored-by: samuel.trahan <Samuel.Trahan@noaa.gov>
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
Merge pull request #151 from JeffBeck-NOAA/feature/fix_bash_l
d1e1815 
Feature/fix bash l
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@climbfuji @DusanJovic-NOAA @junwang-noaa