Add CLM Lake Model and update Flake#1509
Merged
zach1221 merged 180 commits intoApr 26, 2023
Merged
Conversation
setup RT for flake
update FV3 repository
…AA/ufs-weather-model into clm_lake_develop.v9
…elTrahanNOAA/ufs-weather-model into iterative_changes_clm_lake.v9
Collaborator
|
Automated RT Failure Notification |
37 tasks
Collaborator
|
We'll skip Gaea on this PR, so testing is finished and we can begin the merging process @SamuelTrahanNOAA . |
9 tasks
Collaborator
|
CMEPS is ready fe2c158 |
Collaborator
Author
|
The FV3 and CMEPS submodules now point to their authoritative repos and hashes. |
Collaborator
|
I'll request final approval and then we should be able to merge this PR. |
jkbk2004
approved these changes
Apr 26, 2023
DeniseWorthen
approved these changes
Apr 26, 2023
BrianCurtis-NOAA
approved these changes
Apr 26, 2023
sadeghitabas
approved these changes
Apr 26, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the CLM Lake Model, updates the Flake model, and adds an experimental feature to run both NSST and a lake model on lake points. The FV3_HRRR suite uses clm_lake by default, and the long-forgotten control_flake tests now exists.
Top of commit queue on: TBD
Input data additions/changes
HERA: /scratch2/BMC/wrfruc/Samuel.Trahan/lakes/RT/NEMSfv3gfs/input-data-20221101/lake_p8_water_fraction2020
Anticipated changes to regression tests:
Only tests that have lake data and LKM=1 will change results. This is the list:
To test this, I did the following for hera.intel and hera.gnu:
Subcomponents involved:
Combined with PR's (If Applicable):
Commit Queue Checklist:
Linked PR's and Issues:
Testing Day Checklist:
Testing Log (for CM's):