correct tasks calculation in rt.sh so rocoto workflow will run#1431
Closed
SamuelTrahanNOAA wants to merge 3 commits into
Closed
correct tasks calculation in rt.sh so rocoto workflow will run#1431SamuelTrahanNOAA wants to merge 3 commits into
SamuelTrahanNOAA wants to merge 3 commits into
Conversation
16 tasks
16 tasks
Collaborator
|
@SamuelTrahanNOAA we are trying to combine #1425 and #1418 to this PR. I am going to ask Jun and Ratko to create PRs to you branch. Is it ok for you ? |
Collaborator
Author
|
No, I won't have time to test that today because I'm working on two urgent PRs for the RRFS (in a fork). |
Collaborator
|
No problem! I will merge in these PRs separately then. |
Collaborator
Author
|
This PR is already in #1437 so you could merge it with that one. |
Collaborator
That's the option. Thanks for the note. |
16 tasks
Collaborator
|
this pr was merged with #1437. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.Description
The
$TASKScalculation in rt.sh is incorrect; the correct calculations are in run_tests.sh, which breaks the Rocoto workflow. This PR moves those calculations to rt_utils.sh so they can be called from both scripts.It is unlikely this will affect any test on any platform, except when running the Rocoto workflow. However, it should be tested on all platforms with baseline generation just to be sure. To avoid wasting resources, this PR should be combined with another that requires new baselines.
Issue(s) addressed
Fixes #1430
Testing
Hera gnu using rocoto and ecflow.
Dependencies
None.