Skip to content

CCPP/physics v6 documentation updates + empty CCPP phase subroutine cleanup#1355

Merged
jkbk2004 merged 7 commits into
ufs-community:developfrom
grantfirl:v6_to_main_plus_empty_sub
Aug 16, 2022
Merged

CCPP/physics v6 documentation updates + empty CCPP phase subroutine cleanup#1355
jkbk2004 merged 7 commits into
ufs-community:developfrom
grantfirl:v6_to_main_plus_empty_sub

Conversation

@grantfirl
Copy link
Copy Markdown
Collaborator

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

This pull request only updated the ccpp-physics submodule pointer in accordance with NCAR/ccpp-physics#944 which updates the main ccpp-physics branch with documentation updates from the version 6 release and cleans up unnecessary empty CCPP phase subroutines.

Issue(s) addressed

fixes NCAR/ccpp-physics#949

Testing

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

NCAR/ccpp-physics#944
NOAA-EMC/ufsatm#566

@grantfirl
Copy link
Copy Markdown
Collaborator Author

@jkbk2004 A couple of weeks ago, you mentioned something about combining this with other documentation updates. Has there been any movement on the other documentation updates? I'd like not to see NCAR/ccpp-physics#944 get too old and out-of-date. Plus, I've noticed a small bug that needs to be fixed for the SCM introduced in a recently-merged ccpp-physics PR that needs to be fixed and I'm trying to decide whether to add on to #944, do it separately, or add it to other work.

@jkbk2004
Copy link
Copy Markdown
Collaborator

@grantfirl #1354 contains small updates on sphinx style files. We can merge w/o testing. For #1355, we can schedule to merge in early next week (Monday or Tuesday). If you want to add a SCM fix, I think it will be good to separate out. New PR list is not tight coming weeks. I don't see any problem to work on #1355 from Monday. Let me know if this scheduling works.

@jkbk2004
Copy link
Copy Markdown
Collaborator

@grantfirl #1358 was just merged in. We can start working on this PR. With one quick sanity test run, I think we can ask reviewers' approvals.

@jkbk2004
Copy link
Copy Markdown
Collaborator

@grantfirl can you sync up v6_to_main_plus_empty_sub branch to develop? We merged in mom6 update PR late Friday afternoon. With a quick build check, I think we can move on to merge this PR.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

@grantfirl can you sync up v6_to_main_plus_empty_sub branch to develop? We merged in mom6 update PR late Friday afternoon. With a quick build check, I think we can move on to merge this PR.

@jkbk2004 OK, finished merging in the latest develop branch.

@jkbk2004
Copy link
Copy Markdown
Collaborator

@grantfirl PR is ok with cheyenne.intel. But I am double checking with cheyenne.gnu. I think I may confirm with hera/intel/gnu as well.

on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@jkbk2004
Copy link
Copy Markdown
Collaborator

I tested the PR on Cheyenne intel/gnu as well. No impact on BL. We can start merging in the PR.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

I tested the PR on Cheyenne intel/gnu as well. No impact on BL. We can start merging in the PR.

OK, I'm going to start the merge process in ccpp-physics.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

@jkbk2004 NCAR/ccpp-physics#944 is merged. NOAA-EMC/ufsatm#566 is ready for review/merge.

@jkbk2004
Copy link
Copy Markdown
Collaborator

@grantfirl merged NOAA-EMC/ufsatm#566 Can you revert gitmodule here and update fv3 submodule pointer?

@grantfirl
Copy link
Copy Markdown
Collaborator Author

@grantfirl merged NOAA-EMC/fv3atm#566 Can you revert gitmodule here and update fv3 submodule pointer?

@jkbk2004 Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move version 6 release changes to main

5 participants