Skip to content

Fix RAP (Grell Freitas) decomp b4b issues, enable tests in rt.conf/rt_gnu.conf #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
climbfuji wants to merge 8 commits into from
Closed

Fix RAP (Grell Freitas) decomp b4b issues, enable tests in rt.conf/rt_gnu.conf #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2e144fe
Update .gitmodules and submodule pointer for fv3atm for code review a…
climbfuji Jun 5, 2022
b9d5252
Temporarily add tests/rt_rap_decomp.conf
climbfuji Jun 5, 2022
d965579
Add note that regional_spp_sppt_shum_skeb test fails with GNU
climbfuji Jun 5, 2022
e68e7a6
Update submodule pointer for fv3atm
climbfuji Jun 5, 2022
c232177
Enable test regional_spp_sppt_shum_skeb GNU, increase wallclock time …
climbfuji Jun 5, 2022
d5ecdab
Turn on test regional_spp_sppt_shum_skeb in tests/rt_rap_decomp.conf
climbfuji Jun 5, 2022
2f22b22
Revert changes to test regional_spp_sppt_shum_skeb, remove from rt_gn…
climbfuji Jun 5, 2022
d3ed537
Remove temporary file tests/rt_rap_decomp.conf
climbfuji Jun 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
[submodule "FV3"]
path = FV3
url = https://github.com/NOAA-EMC/fv3atm
branch = develop
#url = https://github.com/NOAA-EMC/fv3atm
#branch = develop
url = https://github.com/climbfuji/fv3atm
branch = bugfix/gf_decomp_b4b
[submodule "WW3"]
path = WW3
url = https://github.com/NOAA-EMC/WW3
Expand Down
2 changes: 1 addition & 1 deletion FV3
Open in desktop
Submodule FV3 updated 2 files
+4 −2 .gitmodules
+1 −1 ccpp/physics
6 changes: 2 additions & 4 deletions tests/rt.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,11 @@ COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_RRTMGP,FV3_RAP_sfcdiff,FV3_HRR
RUN | rap_control | | fv3 |
RUN | rap_rrtmgp | | fv3 |
RUN | regional_spp_sppt_shum_skeb | | fv3 |
# This test is not giving the same results (also not in REPRO mode) - needs to be fixed
#RUN | rap_decomp | | |
RUN | rap_decomp | | |
RUN | rap_2threads | - wcoss_cray jet.intel | |
RUN | rap_restart | | | rap_control
RUN | rap_sfcdiff | | fv3 |
# This test is not giving the same results (also not in REPRO mode) - needs to be fixed
#RUN | rap_sfcdiff_decomp | | |
RUN | rap_sfcdiff_decomp | | |
RUN | rap_sfcdiff_restart | | | rap_sfcdiff
RUN | hrrr_control | | fv3 |
RUN | rrfs_v1beta | | fv3 |
Expand Down
6 changes: 2 additions & 4 deletions tests/rt_gnu.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,11 @@ RUN | control_p8
COMPILE | -DAPP=ATM -DCCPP_SUITES=FV3_RAP,FV3_RAP_sfcdiff,FV3_HRRR,FV3_HRRR_smoke,FV3_RRFS_v1beta -D32BIT=ON | | fv3 |

RUN | rap_control | | fv3 |
# This test is not giving the same results (also not in REPRO mode) - needs to be fixed
#RUN | rap_decomp | | |
RUN | rap_decomp | | |
RUN | rap_2threads | | |
RUN | rap_restart | | | rap_control
RUN | rap_sfcdiff | | fv3 |
# This test is not giving the same results (also not in REPRO mode) - needs to be fixed
#RUN | rap_sfcdiff_decomp | | |
RUN | rap_sfcdiff_decomp | | |
RUN | rap_sfcdiff_restart | | | rap_sfcdiff
RUN | hrrr_control | | fv3 |
RUN | rrfs_v1beta | | fv3 |
Expand Down
4 changes: 2 additions & 2 deletions tests/tests/regional_spp_sppt_shum_skeb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
####################################################################
#
# Regional test with stochastic physics (SPP, SPPT, SHUM, and SKEB)
#
#
####################################################################

export TEST_DESCR="Compare regional stochastic physics results with previous trunk version"
Expand Down Expand Up @@ -59,4 +59,4 @@ export SPP_TAU='21600.0,21600.0,21600.0,21600.0,21600.0'
export SPP_SIGTOP1='0.1,0.1,0.1,0.1,0.1'
export SPP_SIGTOP2='0.025,0.025,0.025,0.025,0.025'
export SPP_STDDEV_CUTOFF='1.5,1.5,2.5,1.5,1.5'
export ISEED_SPP='4,4,4,4,4'
export ISEED_SPP='4,4,4,4,4'