Skip to content

Update rt.conf to compile all suites with Intel in debug mode#1230

Closed
climbfuji wants to merge 15 commits into
ufs-community:developfrom
climbfuji:feature/intel_debug_compile_all_suites
Closed

Update rt.conf to compile all suites with Intel in debug mode#1230
climbfuji wants to merge 15 commits into
ufs-community:developfrom
climbfuji:feature/intel_debug_compile_all_suites

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented May 23, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Description

Change the debug compile command for Intel to compile all available suites. This seems to be possible with newer versions of the Intel compilers (it was always possible with GNU). Keep old split compile jobs on outgoing wcoss_dell_p3 and wcoss_cray (there it doesn't work).

Changes are in tests/rt.conf only, thus does not affect GNU tests at all.

Issue(s) addressed

Testing

Regression tests were run on all platforms that use the Intel compiler (since there are no changes that could possibly affect the GNU runs):

  • hera.intel
  • (n.n.) hera.gnu
  • orion.intel
  • cheyenne.intel
  • (n.n.) cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • (more or less) wcoss_dell_p3*
  • (n.n.) opnReqTest for newly added/changed feature
  • (n.n.) CI
  • on wcoss_dell_p3, the following two tests failed, and I believe for unrelated reasons (at the moment, I can't log into wcoss, for whatever reason, it worked this morning):
control_debug
hafs_regional_atm

I forgot to use the new -d (? ; delete successful rundirs immediately) option, thus running out of disk space might have been the problem.

Dependencies

None

on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
@climbfuji climbfuji marked this pull request as ready for review June 6, 2022 02:34
@climbfuji
Copy link
Copy Markdown
Collaborator Author

@junwang-noaa Also here, please add other reviewers as appropriate. Thanks!

Comment thread tests/rt.conf
RUN | regional_debug | | fv3 |

COMPILE | -DAPP=ATM -DDEBUG=ON -DCCPP_SUITES=FV3_RAP,FV3_RAP_cires_ugwp,FV3_RAP_unified_ugwp,FV3_RAP_flake -D32BIT=ON | | fv3 |
COMPILE | -DAPP=ATM -DDEBUG=ON -DCCPP_SUITES=FV3_RAP,FV3_RAP_cires_ugwp,FV3_RAP_unified_ugwp,FV3_RAP_flake -D32BIT=ON | + wcoss_dell_p3 wcoss_cray | fv3 |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we add dell/cray in the platform list? Does it mean this compile job only works on dell/cray?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With WCOSS dell/cray going away soon, maybe we should remove this?

Comment thread tests/rt.conf
RUN | rap_progcld_thompson_debug | | fv3 |

COMPILE | -DAPP=ATM -DDEBUG=ON -DCCPP_SUITES=FV3_RAP_noah,FV3_RAP_RRTMGP,FV3_RAP_sfcdiff,FV3_RAP_noah_sfcdiff_cires_ugwp,FV3_RRFS_v1beta -D32BIT=ON | | fv3 |
COMPILE | -DAPP=ATM -DDEBUG=ON -DCCPP_SUITES=FV3_RAP_noah,FV3_RAP_RRTMGP,FV3_RAP_sfcdiff,FV3_RAP_noah_sfcdiff_cires_ugwp,FV3_RRFS_v1beta -D32BIT=ON | + wcoss_dell_p3 wcoss_cray | fv3 |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@climbfuji climbfuji changed the title DRAFT - Update rt.conf to compile all suites with Intel in debug mode Update rt.conf to compile all suites with Intel in debug mode Jun 6, 2022
@climbfuji
Copy link
Copy Markdown
Collaborator Author

@junwang-noaa @BrianCurtis-NOAA Please see the description in the PR above. Compiling all suites doesn't work on the two WCOSS platforms, presumably because of the older Intel compiler. It works everywhere else. Therefore remove them from the new compile line that compiles all suites into one exectuable (- wcoss_dell_p3 wcoss_cray) and add them explicitly to the old compile lines (+ wcoss_dell_p3 wcoss_cray) - which means that those lines will be ignored for other platforms. This is the syntax we agreed upon a year or so ago in the UFS code manager meetings and that Dusan implemented. Hope this helps.

@climbfuji
Copy link
Copy Markdown
Collaborator Author

@DusanJovic-NOAA Note. I didn't try this on wcoss2 (still haven't had the time to try the tectia client).

@BrianCurtis-NOAA
Copy link
Copy Markdown
Collaborator

@junwang-noaa @BrianCurtis-NOAA Please see the description in the PR above. Compiling all suites doesn't work on the two WCOSS platforms, presumably because of the older Intel compiler. It works everywhere else. Therefore remove them from the new compile line that compiles all suites into one exectuable (- wcoss_dell_p3 wcoss_cray) and add them explicitly to the old compile lines (+ wcoss_dell_p3 wcoss_cray) - which means that those lines will be ignored for other platforms. This is the syntax we agreed upon a year or so ago in the UFS code manager meetings and that Dusan implemented. Hope this helps.

@junwang-noaa I'm not sure how far in advance of WCOSS 1 shutdown we can plan, but would it make sense to combine all of the debug tests (minus the one that uses MULTI_GASES) and just skip them on dell/cray? WCOSS2 uses the newer intel compiler I believe, so it should work OK there.

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA Note. I didn't try this on wcoss2 (still haven't had the time to try the tectia client).

I will run rt on wcoss2, but today it will be down for maintenance.

@climbfuji
Copy link
Copy Markdown
Collaborator Author

@DusanJovic-NOAA Note. I didn't try this on wcoss2 (still haven't had the time to try the tectia client).

I will run rt on wcoss2, but today it will be down for maintenance.

Thanks, Dusan!

@climbfuji
Copy link
Copy Markdown
Collaborator Author

@junwang-noaa @BrianCurtis-NOAA Please see the description in the PR above. Compiling all suites doesn't work on the two WCOSS platforms, presumably because of the older Intel compiler. It works everywhere else. Therefore remove them from the new compile line that compiles all suites into one exectuable (- wcoss_dell_p3 wcoss_cray) and add them explicitly to the old compile lines (+ wcoss_dell_p3 wcoss_cray) - which means that those lines will be ignored for other platforms. This is the syntax we agreed upon a year or so ago in the UFS code manager meetings and that Dusan implemented. Hope this helps.

@junwang-noaa I'm not sure how far in advance of WCOSS 1 shutdown we can plan, but would it make sense to combine all of the debug tests (minus the one that uses MULTI_GASES) and just skip them on dell/cray? WCOSS2 uses the newer intel compiler I believe, so it should work OK there.

@BrianCurtis-NOAA I'll leave that up to you and @junwang-noaa to decide!

jkbk2004 pushed a commit that referenced this pull request Jun 22, 2022
… different than ocean/ice grid #1279, Update rt.conf to compile all suites with Intel in debug mode #1230 (#1256)

* add new files in mom6_files.cmake

* point to mapwav branch for CMEPS

* all tests using cmeps (s2s, hafs, cdeps) pass on cheyenne.intel

* point MOM6 and CMEPS to latest code
@jkbk2004
Copy link
Copy Markdown
Collaborator

combined and merged with #1256

@jkbk2004 jkbk2004 closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiling all CCPP suites fails with the Intel compiler, always successful with GNU

6 participants