Add 2d domain decomposition to the inline post

[JesseMeng-NOAA]

f09e45b
plus UPP post_2d_decomp

Resubmit an update from previous PR, after many updates in upp and other fv3atm submodules.

The community upp is currently decomposed on latitudes (y-direction) only. As the ufs-weather-model is making 2D decomposition in both latitudes and longitudes (Y and X), one of the upp refactoring tasks is to support ufs-weather-model inline post 2D decomposition functionality.

A fv3atm PR was submitted with modified io/ drivers to call upp/post_2d_decomp,
NOAA-EMC/ufsatm#533

The upp/post_2d_decomp branch can be found at
https://github.com/WenMeng-NOAA/UPP/tree/post_2d_decomp

PR Checklist

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

• This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

• An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
  are specified below.

• Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

• New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

• ufs-weather-model/fv3atm/upp 2D decomposed inline post #1078

Testing

To test this PR,

1. Build the BASE with ufs-weather-model/develop
   run control fv3 and regional_control fv3

2. Checkout the branch for this PR
   https://github.com/JesseMeng-NOAA/ufs-weather-model/tree/upp_unify_inline_2d
   run control_2dwrtdecomp and regional_control_2dwrtdecomp

3. Compare the results to confirm identical outputs are reproduced.

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

• hera.intel
• hera.gnu
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss_cray
• wcoss_dell_p3
• opnReqTest for newly added/changed feature
• CI

Dependencies

https://github.com/JesseMeng-NOAA/fv3atm/tree/feature/upp_unify_inline_2d
https://github.com/WenMeng-NOAA/UPP/tree/post_2d_decomp

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

• waiting on Add 2d domain decomposition to the inline post NOAA-EMC/ufsatm#533

[jkbk2004]

@JesseMeng-NOAA I tested ok on Cheyenne/intel: control_2dwrtdecomp and regional_control_2dwrtdecomp. Can you sync up the branch to head of develop: 3 commits behind? So that we can run regression tests.

[JesseMeng-NOAA]

@JesseMeng-NOAA I tested ok on Cheyenne/intel: control_2dwrtdecomp and regional_control_2dwrtdecomp. Can you sync up the branch to head of develop: 3 commits behind? So that we can run regression tests.

Updated

[jkbk2004]

@BrianCurtis-NOAA @MinsukJi-NOAA If possible, go ahead to run RTs on wcoss/wcoss2.

[jkbk2004]

@DusanJovic-NOAA @WenMeng-NOAA RTs all pass. I think the PR is ready to merge. Can you leave review comments?

[jkbk2004]

@JesseMeng-NOAA can you update fv3atm hash and revert fv3atm pointer at gitmodules? so that we can merge in.

[JesseMeng-NOAA]

@JesseMeng-NOAA can you update fv3atm hash and revert fv3atm pointer at gitmodules? so that we can merge in.

Updated.