release/public-v1: bugfixes for no_nsst suites#118
Merged
junwang-noaa merged 2 commits intoMay 11, 2020
Merged
Conversation
Collaborator
|
Thanks for fixing the CCPP version number. The title of this PR alarmed me, but I see that the bug fix does not change answers, so that is a relief. |
Collaborator
Author
|
Regression testing on hera.intel, cheyenne.intel, cheyenne.gnu against existing baseline: all tests pass, regression test logs updated in PR. |
junwang-noaa
approved these changes
May 7, 2020
Collaborator
Author
|
@DusanJovic-NOAA can you please have a look at this PR and NOAA-EMC/ufsatm#110? They need to be merged into the public release branch for the 1.1.0 release. Tiny bug fix of the version number in the CCPP suite definition files for the no_nsst SDFs. Jun already reviewed and approved both. Thanks ... |
DusanJovic-NOAA
approved these changes
May 11, 2020
Collaborator
Author
|
Hmmm I think this was the wrong one ... we should have done fv3atm first? |
junwang-noaa
added a commit
that referenced
this pull request
May 11, 2020
This reverts commit a3769c7.
Collaborator
|
Sorry, I thought I had committed fv3atm, will revert the commit.
…On Mon, May 11, 2020 at 11:27 AM Dom Heinzeller ***@***.***> wrote:
Hmmm I think this was the wrong one ... we should have done fv3atm first?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#118 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TM5OXLUBU76ZCOGOBLRRAKMBANCNFSM4M2TBM3Q>
.
|
junwang-noaa
added a commit
that referenced
this pull request
May 11, 2020
climbfuji
commented
Jun 15, 2020
epic-cicd-jenkins
pushed a commit
that referenced
this pull request
Apr 17, 2023
Changes to post file names for real-time system and reduce wall clock…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update .gitmodules and submodule pointer for fv3atm for code review and testing.
Associated PRs:
NOAA-EMC/ufsatm#110
#118
For regression testing information, see below.