Added hailcast code in FV3/atmos_cubed_sphere#1164
Closed
ywangwof wants to merge 2 commits into
Closed
Conversation
6 tasks
Collaborator
Author
|
.gitmodules was modified for both PRs. Thanks. |
Collaborator
|
The dycore PR#164 was committed in ufs-weather-model PR#1156. The PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.
Instructions: All subsequent sections of text should be filled in as appropriate.
To produce the hail size diagnostic output, this namelist block should be added to
input.nml.and this entry should be added to
diag_tableIf either
input.nmlordiag_tableis not changed, it will do nothing.Description
Add FV3-HAILCAST code with FV3/atmos_cubed_sphere for hail size diagnostic output. It will not change the answers and no library update is needed.
Issue(s) addressed
see PR #164.
Testing
It was tested on Jet and a NSSL machine - Odin with Intel compiler. No regression tests needed since it will not change the model, but just add a diagnostic output.
Dependencies