Bug/debugww3fix

[JessicaMeixner-NOAA]

PR Checklist

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

• This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

• An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
  are specified below.

• Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

• New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

This is a PR that updates WW3, the dev/ufs-weather-model branch with the NOAA-EMC develop branch merged in. The update of note is a fix for when WW3 is compiled with DEBUG flags. See issue: This fix was provided by @kgerheiser

No answers are changed with this PR. No new input is required.

Issue(s) addressed

• fixes CMake build for WW3 fails when compiling S2SW with -DDEBUG=ON #1133

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

The following regression tests passed: hera.intel gaea.intel wcoss_cray
The following regression tests are running but have not yet completed: wcoss_dell_p3, orion.intel
I do not have access to jet or Cheyenne.

The following ORT test passed:
./opnReqTest -n cpld_control_c96_p8 -c thr,rst,dbg,fhz
and the log file was included.

• hera.intel
• hera.gnu
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss_cray
• wcoss_dell_p3
• opnReqTest for newly added/changed feature
• CI

Dependencies

• waiting on Merge develop to dev/ufs-weather-model branch 20220324 NOAA-EMC/WW3#648

[junwang-noaa]

@JessicaMeixner-NOAA Is it OK we can combine this PR with Dom's PR #1130 which does not change results?

[JessicaMeixner-NOAA]

@junwang-noaa I think that would be great! Please let me know if there's anything I need to do.

[junwang-noaa]

@JessicaMeixner-NOAA Do you plan to make further changes in your ww3 branch, if not, we can ask @climbfuji to point to your ww3 branch in his ufs-weather-model branch.

[JessicaMeixner-NOAA]

@junwang-noaa No I do not plan to make any further changes to the WW3 branch.

[climbfuji]

@JessicaMeixner-NOAA @junwang-noaa I pulled the changes from this PR into #1130, as requested.

[JessicaMeixner-NOAA]

Combined with #1130