Skip to content

Ci fix#1119

Closed
MinsukJi-NOAA wants to merge 6 commits into
ufs-community:developfrom
MinsukJi-NOAA:ci_fix
Closed

Ci fix#1119
MinsukJi-NOAA wants to merge 6 commits into
ufs-community:developfrom
MinsukJi-NOAA:ci_fix

Conversation

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@github-actions github-actions Bot removed the run-ci label Mar 16, 2022
@MinsukJi-NOAA MinsukJi-NOAA added the No Baseline Change No Baseline Change label Mar 17, 2022
@github-actions
Copy link
Copy Markdown

@MinsukJi-NOAA please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date

Comment thread tests/ci/ci.test
regional_control
thr dcp
cpld_control_c96_p8
cpld_control_c96_noaero_p8
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Developers are looking into the issue with cpld_control_c96_p8 (issue #1103), maybe we can wait until that is fixed. Since the control test is using GOCART, I'd suggest not changing the test case.

@MinsukJi-NOAA
Copy link
Copy Markdown
Contributor Author

Closing since the code changes were merged via #1087. The related issue #1115 will remain open for aerosol model issue with gnu compiler.

@MinsukJi-NOAA MinsukJi-NOAA deleted the ci_fix branch June 6, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants