land surface upgrades for p8#1095
Conversation
fa9b372 to
38aa634
Compare
|
@HelinWei-NOAA Would you please fill up the checklist in the top of PR? In the description, write done which tests are expected to change results. Thanks |
|
@HelinWei-NOAA It looks to me, your fv3 branch is updated with revision 5917500 in your fv3atm PR, but your ufs-weather-model branch still points to 94d4027, please see: https://github.com/HelinWei-NOAA/ufs-weather-model/tree/lsm_upgrades_for_p8c |
|
updated
|
|
Done
|
|
@HelinWei-NOAA please bring these up to date with respective authoritative repositories
|
done |
|
@HelinWei-NOAA Would you please run the two tests on hera from your branch? Thanks. @MinsukJi-NOAA FYI. |
|
@junwang-noaa running now |
|
Both tests have been successful on Hera and WCOSS.
|
|
Would you please check if OpnReqTests_control_p8_hera.intel.log and OpnReqTests_control_c96_noaero_p8_hera.intel.log under ufs-weather-model/tests show ORTs ran successfully, if yes, please commit to your ufs-weather-model branch. After that, please sync with the top of ufs-weather-model develop branch. |
|
@junwang-noaa I have OpnReqTests_control_p8_hera.intel.log and OpnReqTests_cpld_control_c96_noaero_p8_hera.intel.log. They show ORTS ran successfully. The file name of the second log file is different from what you refer to. Should I do another test for uncoupled runs? |
|
Sorry, your log file names are correct. Please commit to your branch. |
|
done
|
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
Just figured out, the RRFS related RTs use rap.nml.IN. |
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
|
Automated RT Failure Notification |
on-behalf-of @ufs-community <brian.curtis@noaa.gov>
|
On gaea, the regional_3km test times out with wall clock 10mins. |
|
Automated RT Failure Notification |
|
Automated RT Failure Notification |
|
The baseline was not moved to emc.nemspara location on hera |
|
@HelinWei-NOAA The wcoss dell/cray log files are on hera at: /scratch1/NCEPDEV/stmp2/Jun.Wang/wcosslog/., please commit to your branch. Thanks |
…eather-model into lsm_upgrades_for_p8c
|
@HelinWei-NOAA @ChunxiZhang-NOAA @grantfirl We have disk space issue on hera. A ticket was submitted to hera helpdesk. |
|
@HelinWei-NOAA Your fv3 PR was merged, please update fv3 submodule to noaa-emc fv3 repo develop branch in your ufs-weather-model branch, fv3 revision: d86aba4. Please make sure your fv3 branch points to correct revision |
|
Automated RT Failure Notification |
PR Checklist
This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.
The results from all suites using Noah-MP LSM will be changed because of the physics upgrades.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
To address some biases found in PT7
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs