Skip to content

[production/AQM.v7] Merge the changes to address NCO's review comments on AQMv7 delivery package partly#965

Merged
chan-hoo merged 3 commits into
ufs-community:production/AQM.v7from
JianpingHuang-NOAA:feature/AQMv7_release_v4
Nov 6, 2023
Merged

[production/AQM.v7] Merge the changes to address NCO's review comments on AQMv7 delivery package partly#965
chan-hoo merged 3 commits into
ufs-community:production/AQM.v7from
JianpingHuang-NOAA:feature/AQMv7_release_v4

Conversation

@JianpingHuang-NOAA
Copy link
Copy Markdown

This PR is used to address Issue 964 (#964) partly

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • hercules.intel
  • cheyenne.intel
  • cheyenne.gnu
  • derecho.intel
  • gaea.intel
  • gaeac5.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

@chan-hoo chan-hoo changed the title Merge the changes to address NCO's review comments on AQMv7 delivery package partly [production/AQM.v7] Merge the changes to address NCO's review comments on AQMv7 delivery package partly Nov 6, 2023
@chan-hoo
Copy link
Copy Markdown
Collaborator

chan-hoo commented Nov 6, 2023

@JianpingHuang-NOAA, please do not remove anything in manage_externals. I'll move it on my end.

@chan-hoo
Copy link
Copy Markdown
Collaborator

chan-hoo commented Nov 6, 2023

@JianpingHuang-NOAA, why do you delete the input files for FV3_GFS_v16 such as diag_table and field_table in the parm directory? How does your NRT run without those files?

@JianpingHuang-NOAA
Copy link
Copy Markdown
Author

Yes, I only keep those related aqm. I did not find any impact on our model running and results. I have completed the tests

@chan-hoo
Copy link
Copy Markdown
Collaborator

chan-hoo commented Nov 6, 2023

@JianpingHuang-NOAA, which CCPP physics suite are you using in your NRT?

@JianpingHuang-NOAA
Copy link
Copy Markdown
Author

@JianpingHuang-NOAA, please do not remove anything in manage_externals. I'll move it on my end.

I deleted "test" subdirectory only under ~/manage_external. I am not comfortable with other changes. So I leave them for you.

@chan-hoo
Copy link
Copy Markdown
Collaborator

chan-hoo commented Nov 6, 2023

@JianpingHuang-NOAA, I can see the files in your branch, but the PR is saying they are deleted. Strange ....

@chan-hoo
Copy link
Copy Markdown
Collaborator

chan-hoo commented Nov 6, 2023

@JianpingHuang-NOAA, I got it now. They have different names for AQM. Sorry. I was confused. Approving now.

@chan-hoo chan-hoo merged commit 52016a4 into ufs-community:production/AQM.v7 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants