[develop] Update spack-stack on noaacloud

[EdwardSnyder-NOAA]

DESCRIPTION OF CHANGES:

This PR updates the spack-stack used to build the SRW App to the latest spack-stack installed version. Changes also include using the new conda environment (workflow_tools), and updates the NCORES_PER_NODE variable to use the maximum compute cores for each Parallel Works Cloud Service Provider (PW CSPs).

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

TESTS CONDUCTED:

• hera.intel
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss2.intel
• NOAA Cloud (indicate which platform) Ran on all three PW CSPs
• Jenkins
• fundamental test suite
  All test pass except the MET VX test: grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16. That's because PR [develop] MET_verification: use modules met, metplus  #826 was not tested on the NOAA Cloud platforms. Issue Use MET/METplus modules on NOAA Cloud #905 was opened to track the progress of using the MET and METplus modules on NOAA Cloud.
• comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

No documentation updates are needed

ISSUE:

This addresses issue #881, which is cannot run the SRW App on NOAA Cloud

CHECKLIST

• My code follows the style guidelines in the Contributor's Guide
• I have performed a self-review of my own code using the Code Reviewer's Guide
• I have commented my code, particularly in hard-to-understand areas
• My changes need updates to the documentation. I have made corresponding changes to the documentation
• My changes do not require updates to the documentation (explain).
• My changes generate no new warnings
• New and existing tests pass with my changes
• Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

• Work In Progress
• bug
• enhancement
• documentation
• release
• high priority
• run_ci
• run_we2e_fundamental_tests
• run_we2e_comprehensive_tests
• Needs Cheyenne test
• Needs Jet test
• Needs Hera test
• Needs Orion test
• help wanted

CONTRIBUTORS (optional):

@natalie-perlin for installing workflow_tools on Azure and GCP.

[natalie-perlin]

MET and METplus modules in spack-stack have different environment variables. This may require SRW to be adapted to use MET and METplus modules

[MichaelLueken]

@EdwardSnyder-NOAA - Overall these changes look good!

I noted that two lines, loading intel and impi, had been commented out in build_noaacloud_intel.lua. If these will be used in the future, it is fine to keep them in and commented. However, if they won't be used, please remove these two lines to help clean up the modulefile.

Additionally, there is a conflict in the srw_common_spack.lua modulefile. Please merge the latest HEAD of develop into your feature/update-spack-stack-noaacloud branch and resolve the conflict. Once complete, I can give my approval and move forward with merging this work.

[MichaelLueken]

@EdwardSnyder-NOAA - Thanks for addressing the conflict and removing the comments from the modulefile! Approving and merging this work now.