[develop] Update forecast metric test script#882
Conversation
RatkoVasic-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me
MichaelLueken
left a comment
There was a problem hiding this comment.
These changes look good to me! However, I did note that the old regional_workflow conda environment is still being loaded. In PR #793, the conda environment was changed to workflow_tools. It would be a good idea to change line 49 so that it reads:
conda activate workflow_tools
The test was run with both regional_workflow and workflow_tools. Both tests successfully passed. Will approve after regional_workflow has been updated to workflow_tools.
MichaelLueken
left a comment
There was a problem hiding this comment.
Thanks, @clouden90! Approving now.
|
The Cheyenne Intel WE2E coverage tests were manually run on Hera and all successfully passed: The Cheyenne GNU WE2E coverage tests were manually run on Hera and all successfully passed: Unfortunately, the |
|
The Jet tests were manually run and have successfully completed: Now moving forward with merging this work. |
DESCRIPTION OF CHANGES:
Update
srw_metric_example.shto remove the explicit setting ofMET_INSTALL_DIRandMET_BIN_EXECenvironment variables. (This change comes after #826, where these variables are sourced directly from the modulefiles.)TESTS CONDUCTED:
To start, git clone the feature branch, then navigate to the ufs-srweather-app folder and proceed to check out the external repositories. Set the following environment variables: WORKSPACE (path to your
ufs-srweather-appfolder), SRW_PLATFORM (e.g.,hera), SRW_COMPILER (e.g.,intel), and SRW_PROJECT (e.g.,nems). Once these are set, run the command./.cicd/scripts/srw_metric_example.sh. This process is expected to take around 2 hours to complete. Afterward, you should find an output file named skill-score.out that contains the skill score index. Tests have been conducted on Hera and Jenkins pipeline.CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):