[develop] Linting to the standard at pylint v2.16.

[christinaholtNOAA]

DESCRIPTION OF CHANGES:

Update the version of pylint in the GitHub Actions workflow to be consistent with the version installed on-prem. On Hera, that's v2.16. I am assuming that's consistent with the other platforms.

This required linting several files to get the test to pass with a 10/10 score.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

TESTS CONDUCTED:

Only pylint and unittests were run on Hera.

DEPENDENCIES:

n/a

DOCUMENTATION:

n/a

ISSUE:

Fixes issue #787.

CHECKLIST

• My code follows the style guidelines in the Contributor's Guide
• I have performed a self-review of my own code using the Code Reviewer's Guide
• I have commented my code, particularly in hard-to-understand areas
• My changes need updates to the documentation. I have made corresponding changes to the documentation
• My changes do not require updates to the documentation (explain).
• My changes generate no new warnings
• New and existing tests pass with my changes
• Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

• Work In Progress
• bug
• enhancement
• documentation
• release
• high priority
• run_ci
• run_we2e_fundamental_tests
• run_we2e_comprehensive_tests
• Needs Cheyenne test
• Needs Jet test
• Needs Hera test
• Needs Orion test
• help wanted

[MichaelLueken]

@christinaholtNOAA Tested linting on Hera and Jet. Linting passed with rating of 10.00/10. The srw_unittest.sh script was also run on Jet and the tests successfully passed. Approving this PR now.

[mkavulich]

Looks good to me, just had one question but not a hold-up to merge. Code now lints 10/10 on prem.

[mkavulich]

Was there a reason to not use "with" here for the temporary directory?