[develop] Input namelist related changes needed for RRFS

[danielabdi-noaa]

DESCRIPTION OF CHANGES:

This PR brings back input namelist related changes from RRFS_dev1.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

TESTS CONDUCTED:

• hera.intel
  Run community_ensemble_2mems_stoch
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss2.intel
• NOAA Cloud (indicate which platform)
• Jenkins
• fundamental test suite
• comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

None

DOCUMENTATION:

ISSUE:

CHECKLIST

• My code follows the style guidelines in the Contributor's Guide
• I have performed a self-review of my own code using the Code Reviewer's Guide
• I have commented my code, particularly in hard-to-understand areas
• My changes need updates to the documentation. I have made corresponding changes to the documentation
• My changes do not require updates to the documentation (explain).
• My changes generate no new warnings
• New and existing tests pass with my changes
• Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

• Work In Progress
• bug
• enhancement
• documentation
• release
• high priority
• run_ci
• run_we2e_fundamental_tests
• run_we2e_comprehensive_tests
• Needs Cheyenne test
• Needs Jet test
• Needs Hera test
• Needs Orion test
• help wanted

CONTRIBUTORS (optional):

[venitahagerty]

Machine: hera
Compiler: intel
Job: WE
Repo location: /scratch1/BMC/zrtrr/rrfs_ci/autoci/pr/1328741051/20230426132015/ufs-srweather-app
Build was Successful
Rocoto jobs started
Experiment done: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
2023-04-26 13:59:07 +0000 :: hfe07 :: This cycle is complete: Success
Experiment failed: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
2023-04-26 14:13:49 +0000 :: hfe07 :: Task run_MET_PcpCombine_fcst_APCP01h_mem000, jobid=44214516, in state DEAD (FAILED), ran for 11.0 seconds, exit status=256, try=2 (of 2)
Experiment done: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
2023-04-26 13:56:24 +0000 :: hfe07 :: This cycle is complete: Success
Experiment done: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
2023-04-26 13:52:38 +0000 :: hfe07 :: This cycle is complete: Success
Experiment done: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional_plot
2023-04-26 13:54:09 +0000 :: hfe07 :: This cycle is complete: Success
Experiment done: pregen_grid_orog_sfc_climo
2023-04-26 13:53:27 +0000 :: hfe07 :: This cycle is complete: Success
Experiment done: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
2023-04-26 13:53:38 +0000 :: hfe07 :: This cycle is complete: Success
If test failed, please make changes and add the following label back:
ci-hera-intel-WE

[christinaholtNOAA]

I have just a few small comments below. Otherwise, it looks good. Thanks for preparing this smaller scope PR!

[BenjaminBlake-NOAA]

These changes look good to me. I have one question which I'll include here - GitHub isn't letting me comment on the exact line (not sure why).

Should lines 455 and 457 of exregional_run_fcst.sh use cp_vrfy instead of ln_vrfy? The current version of the script uses cp_vrfy so I was just curious why this was changed.

[danielabdi-noaa]

These changes look good to me. I have one question which I'll include here - GitHub isn't letting me comment on the exact line (not sure why).

Should lines 455 and 457 of exregional_run_fcst.sh use cp_vrfy instead of ln_vrfy? The current version of the script uses cp_vrfy so I was just curious why this was changed.

@BenjaminBlake-NOAA There are now four different input namelists as opposed to the one before. With a symlink it is easier to identify which namelist is used.

[BenjaminBlake-NOAA]

@danielabdi-noaa I agree a symlink makes more sense, thanks for explaining!

[MichaelLueken]

@danielabdi-noaa These changes look good to me! Approving now.

[MichaelLueken]

@danielabdi-noaa -

The Jenkins tests failed to make it past the Initialize step on Cheyenne due to an issue with Jenkins. The WE2E coverage tests were manually ran and all passed (it is important to note that the nco_grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km test wasn't run, since it would likely fail in the run_post tasks).

Following the update to the PrgEnv on Gaea last week, the SRW will no longer build on the machine with it's current modulefile. PR #799 will update the build_gaea_intel.lua modulefile so that it will once again build on Gaea.

The Hera Intel grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta test failed in the run_fcst task (issue #731).

Since the failures are expected, I will now merge this work.