[develop]: Fix a bug in devbuild.sh with a case statement#715
Merged
Conversation
natalie-perlin
approved these changes
Apr 6, 2023
RatkoVasic-NOAA
approved these changes
Apr 6, 2023
MichaelLueken
approved these changes
Apr 7, 2023
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
This modification is meant to generalize the use of | to separate words in bash within devbuild.sh. The build was tested on Orion, which successfully built without issue. Approving now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
The "
," separated words in the bash case statement of file devbuild.sh does not work on my machine, MacOS Monterey and bash version 5.2.15. For generality, I think it had better use "|" to seperate words in the bash case statement.Type of change
TESTS CONDUCTED:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR: