[develop] Change the build log output file extension from log to txt in prod bucket#706
Closed
BruceKropp-Raytheon wants to merge 2 commits into
Closed
[develop] Change the build log output file extension from log to txt in prod bucket#706BruceKropp-Raytheon wants to merge 2 commits into
BruceKropp-Raytheon wants to merge 2 commits into
Conversation
MichaelLueken
approved these changes
Mar 31, 2023
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
These changes are renaming the build log file to a txt file in the Jenkinsfile and build script. Approving PR.
Collaborator
|
@BruceKropp-Raytheon Looking at the pipeline.log artifact, I see the following: So, I don't think that we will see the update for the build files from log to txt in the pipeline. This was seen in @kbooker79's PR that updated the path of the S3 bucket to the new OAR account. Once this PR is merged, all subsequent testing should replace the log files with txt files for the build documentation. |
22 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
When pipeline files are archived to s3 bucket, retrieving the file via a browser attempts to render/display files of known extensions. A browser doesn't generally understand what to do with a .log extension (e.g. build.log). For ease of use in the CI Dashboard, which is a static HTML page, the s3 archived build log needs a .txt extension (e.g. build.txt).
Type of change
TESTS CONDUCTED:
This is CI/CD support, not model or app code. The resulting build log (.txt) was viewed within a browser following manual steps.
DEPENDENCIES:
would need a pipeline PR build stage (test stage not required) to see that the correct file extension is applied
DOCUMENTATION:
Any material that mentions the build log filename explicitly, in form of: srw_build-${PLATFORM}-${COMPILER}.log
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):