[develop] Bug fix for broken symlink in verification test directory#704
Closed
mkavulich wants to merge 2 commits into
Closed
[develop] Bug fix for broken symlink in verification test directory#704mkavulich wants to merge 2 commits into
mkavulich wants to merge 2 commits into
Conversation
Fix broken symlink in verification test directory
… is now confirmed fixed on the command line.
mkavulich
requested review from
BenjaminBlake-NOAA,
EdwardSnyder-NOAA,
JeffBeck-NOAA,
MichaelLueken,
RatkoVasic-NOAA,
chan-hoo,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
dmwright526,
gsketefian,
gspetro-NOAA,
jkbk2004,
mark-a-potts,
natalie-perlin,
panll,
willmayfield and
ywangwof
as code owners
MichaelLueken
approved these changes
Mar 29, 2023
Collaborator
MichaelLueken
left a comment
MichaelLueken
left a comment
There was a problem hiding this comment.
In PR #686, grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_HRRR was renamed to grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16. This PR corrects the naming of the WE2E test for MET_ensemble_verification. Approving now.
MichaelLueken
added
the
run_we2e_coverage_tests
RatkoVasic-NOAA
approved these changes
Mar 29, 2023
JeffBeck-NOAA
approved these changes
Mar 29, 2023
Collaborator
|
@mkavulich Since this modification has been made to @christinaholtNOAA's PR #676, I will go ahead and resubmit the Jenkins tests and merge this PR's update through #676. |
Collaborator
Author
|
@MichaelLueken Thanks for noticing that, I forgot that I applied that fix there when settling merge conflicts. I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
In one of the final changes for #686 I renamed a file for one of the new consolidated WE2E tests, but failed to update the symbolic link from the "MET_ensemble_verification" test name. This commit fixes the link.
Type of change
TESTS CONDUCTED:
Ran
./run_WE2E_tests.pywith the fixed symlink test, confirmed that the test was now able to be created and run correctly. Because this change does not affect any code, scripts, or automated tests (this test alias is not in any of the automated tests), I believe it does not require additional testing and can be merged as-is.DEPENDENCIES:
None
DOCUMENTATION:
None
ISSUE:
None
CHECKLIST