[develop] Fix rrfs_utils bug in devbuild script#669
Merged
MichaelLueken merged 1 commit intoMar 14, 2023
Merged
Conversation
danielabdi-noaa
approved these changes
Mar 13, 2023
Collaborator
danielabdi-noaa
left a comment
There was a problem hiding this comment.
Thanks, I need this PR.
MichaelLueken
approved these changes
Mar 14, 2023
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
@EdwardSnyder-NOAA This change looks good to me! I was able to clone your branch and build the GSI and RRFS_UTILS without issue. Approving this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
The
devbuild.shis unable to build the rrfs_utils app even if it is being called from the command line like in:./devbuild.sh -p=<platform> allor./devbuild.sh -p=<platform> gsi rrfs_utils. After some investigation it appears the-DBUILD_RRFS_UTILSoption was accidently removed from the cmake settings in PR #549. Adding this line back in causes the rrfs_utils app to build again.Moved into a separate PR since a number of us need to build the
rrfs_utilsapp.Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):