Skip to content

[develop] Fix rrfs_utils bug in devbuild script#669

Merged
MichaelLueken merged 1 commit into
ufs-community:developfrom
EdwardSnyder-NOAA:bugfix/devbuild-rrfs_utils
Mar 14, 2023
Merged

[develop] Fix rrfs_utils bug in devbuild script#669
MichaelLueken merged 1 commit into
ufs-community:developfrom
EdwardSnyder-NOAA:bugfix/devbuild-rrfs_utils

Conversation

@EdwardSnyder-NOAA
Copy link
Copy Markdown
Collaborator

@EdwardSnyder-NOAA EdwardSnyder-NOAA commented Mar 13, 2023

DESCRIPTION OF CHANGES:

The devbuild.sh is unable to build the rrfs_utils app even if it is being called from the command line like in:
./devbuild.sh -p=<platform> all or ./devbuild.sh -p=<platform> gsi rrfs_utils. After some investigation it appears the -DBUILD_RRFS_UTILS option was accidently removed from the cmake settings in PR #549. Adding this line back in causes the rrfs_utils app to build again.

Moved into a separate PR since a number of us need to build the rrfs_utils app.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

@EdwardSnyder-NOAA EdwardSnyder-NOAA changed the title added rrfs utils option back to cmake settings [develop] Fix rrfs_utils bug in devbuild script Mar 13, 2023
@EdwardSnyder-NOAA EdwardSnyder-NOAA marked this pull request as ready for review March 13, 2023 21:29
Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I need this PR.

Copy link
Copy Markdown
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwardSnyder-NOAA This change looks good to me! I was able to clone your branch and build the GSI and RRFS_UTILS without issue. Approving this now.

@MichaelLueken MichaelLueken merged commit 8a4a443 into ufs-community:develop Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants