[develop] Add upgrade option to check_for_preexist_dir.#645
Merged
MichaelLueken merged 4 commits intoApr 4, 2023
Merged
Conversation
27dfa55 to
f9d3023
Compare
gsketefian
reviewed
Mar 7, 2023
gsketefian
approved these changes
Mar 24, 2023
65a6b9b to
fa240ec
Compare
MichaelLueken
approved these changes
Apr 3, 2023
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
@danielabdi-noaa These changes look good to me! I was able to clone this work on Jet, submit the fundamental WE2E tests, then reran them using the new reuse method. The new method worked as described in the PR. All tests for both runs successfully passed. Approving these changes now.
Collaborator
|
@danielabdi-noaa The Jenkins tests on Cheyenne Intel have finally passed successfully. Moving forward with merging this work now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Addresses issue #655. Add
upgradeoption besidesdelete,rename,quitwhen checking for existing experiment directory (or another folder). For EXPTDIR the behavior is different from other directories. The "upgrade" option behaves likersyncforEXPTDIR. The workflow generation is handled by python code in SRW app, thereforecheck_for_preexist_dir.pyhandles that. For other directories, the shell version of the script is used, andupgrademeans reuse existing directory. Apparently this option is sometimes useful for RRFS_dev1 workflow runs.Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):