Skip to content

[develop] Add radar reflectivity task.#638

Merged
MichaelLueken merged 14 commits into
ufs-community:developfrom
danielabdi-noaa:feature/task_radarref
Apr 14, 2023
Merged

[develop] Add radar reflectivity task.#638
MichaelLueken merged 14 commits into
ufs-community:developfrom
danielabdi-noaa:feature/task_radarref

Conversation

@danielabdi-noaa

@danielabdi-noaa danielabdi-noaa commented Mar 6, 2023

Copy link
Copy Markdown
Collaborator

DESCRIPTION OF CHANGES:

Add process_radarref task from RRFS_dev1.
Note that there is no workflow so this PR can not be run independently until then.
However, it did successfully run for both spinup/production cycles in PR #540.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

@panll panll left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Hera. It works fine.

Comment thread jobs/JREGIONAL_PROCESS_BUFR

@christinaholtNOAA christinaholtNOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left several suggestions for clean up below, but we definitely need to make sure that we aren't pointing to unsupported data paths before merging.

Comment thread scripts/exregional_process_radarref.sh Outdated
Comment thread jobs/JREGIONAL_PROCESS_RADARREF
Comment thread scripts/exregional_process_radarref.sh Outdated
Comment thread scripts/exregional_process_radarref.sh
Comment thread scripts/exregional_process_radarref.sh Outdated
Comment thread scripts/exregional_process_radarref.sh Outdated
Comment thread scripts/exregional_process_radarref.sh
Comment thread scripts/exregional_process_radarref.sh Outdated
Comment thread ush/machine/jet.yaml
Comment thread ush/machine/jet.yaml Outdated
@christinaholtNOAA christinaholtNOAA changed the title [develop] Add raddar reflectivity task. [develop] Add radar reflectivity task. Mar 27, 2023

@christinaholtNOAA christinaholtNOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more tiny change request, but the changes look good.

It looks like the supported radar obs paths are here:

Jet: /public/data/radar/mrms
Hera: /scratch2/BMC/public/data/radar/nssl/mrms/conus

@mkavulich Might find this useful for his work with data retrieval, too.

Comment thread ush/config_defaults.yaml Outdated
@danielabdi-noaa

Copy link
Copy Markdown
Collaborator Author

One more tiny change request, but the changes look good.

It looks like the supported radar obs paths are here:

Jet: /public/data/radar/mrms Hera: /scratch2/BMC/public/data/radar/nssl/mrms/conus

@mkavulich Might find this useful for his work with data retrieval, too.

@christinaholtNOAA Note that those are paths for realtime forecasts only. You can find the full list of observation paths for realtime/retro runs in this commit for hera/jet/wcoss2: obs data paths

@christinaholtNOAA christinaholtNOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@christinaholtNOAA

Copy link
Copy Markdown
Collaborator

@MichaelLueken In our RRFS dev merge discussion yesterday we chatted about pushing this one through when it's ready. If we can go ahead with that, it would be helpful. Thanks!

@MichaelLueken

Copy link
Copy Markdown
Collaborator

@danielabdi-noaa I'm working on reviewing and testing this PR now. It looks like there is a conflict in ush/config_defaults.yaml. Please merge develop into your feature/task_radarref branch one more time and I will approve this work and kick off the Jenkins tests. Thanks!

@danielabdi-noaa

Copy link
Copy Markdown
Collaborator Author

@MichaelLueken I have resolved the conflicts. You can kick off the Jenkins tests now.

@MichaelLueken MichaelLueken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielabdi-noaa These changes look good to me! The necessary components to run this task and the process bufr task will be completed in PR #725. Approving now.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Apr 14, 2023
@MichaelLueken

Copy link
Copy Markdown
Collaborator

The Jenkins tests have completed. The Hera Intel tests failed. Manually running them, all tests successfully passed (with the exception of grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR, which failed due to issue #688). Moving forward with merging this work now.

@MichaelLueken MichaelLueken merged commit 662ff2a into ufs-community:develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Radar Reflectivity observations processing task is needed for RRFS

5 participants