Update README documentation from release branch#62
Conversation
…ourced by the develop branch of regional_workflow
mkavulich
requested review from
JeffBeck-NOAA,
JulieSchramm and
gsketefian
as code owners
|
I'm aware that ideally this issue would be resolved by cherry-picking all needed commits from the release branch, but that would require extensive testing due to various changes made in the interim, and this needs to be fixed urgently for further development purposes. Fully syncing master with the release branch can wait until after Thanksgiving. 🦃 |
christinaholtNOAA
left a comment
christinaholtNOAA
left a comment
There was a problem hiding this comment.
My tests on Jet are failing on the build. l will need some additional help with this test.
So far, I have tried to point to the develop branch of ufs-weather-model after failures due to a severely reduced set of CCPP packages in the release branch. And am now failing with issues seemingly related to inline post. Will follow up in person....
| # is "..", one directory up from the build directory | ||
| # -DCCPP_SUITES A comma-separated list of CCPP suites to build with the UFS weather | ||
| # model. See the User's Guide for a full list of available suites. | ||
|
|
There was a problem hiding this comment.
This should have a cd src first.
There was a problem hiding this comment.
Well, this was me being dumb...please disregard.
| # Prior to building, you must set up the environment so cmake can find the appropriate compilers | ||
| # and libraries. For instructions specific to supported platforms, see the included "README" files | ||
| # in this directory. These README files give instructions assuming a bash or ksh login shell, for | ||
| # csh and tcsh users you will have to modify the commands for setting envronment variables. |
There was a problem hiding this comment.
It would be helpful to have a line below that says you should source one of these READMEs, since the old system did the equivalent for you.
|
@mkavulich @christinaholtNOAA @gsketefian, the default Externals.cfg for the develop branch of ufs-srweather-app needs to be changed to grab the develop branch of ufs-weather-model, not release/public-v2. My first build error was related to missing CCPP suites. @mkavulich, would you mind making that switch and pushing it to this PR? Now, I'm getting the following when building ufs-weather-model: /lfs4/BMC/wrfruc/beck/ufs-srweather-app_Mike/src/ufs_weather_model/FV3/fv3_cap.F90(1157): error #6632: Keyword arguments are invalid without an explicit interface. [EPOCH] |
|
@JeffBeck-NOAA The top of develop does not work, either. |
Yes, the modules in the README files are currently based off the release branches for all repositories. A set of develop branch repo hashes (could be the HEAD for all) will need to be defined in the Externals.cfg file, along with a set of compatible modules for those branches in the README files. Once that is set up, then the compile should work. |
|
Since this quick fix turned out to be a dead end, I am closing this PR to open a new, better one merging commits from the release branch (to go in after #63) |
4 participants
DESCRIPTION OF CHANGES:
Bring over README documentation from release branch since it is now sourced by the develop branch of regional_workflow (since commit NOAA-EMC/regional_workflow@0711f0e). Therefore these files are needed for continued development on the regional_workflow repository from develop.
TESTS CONDUCTED:
None yet.
ISSUE (optional):
Partially resolves #57