[develop] Rename variables that store task names#598
Merged
MichaelLueken merged 3 commits intoFeb 9, 2023
Conversation
…istent with naming of other per-task variable names like PPN_[...] and WTIME_[...].
…ocoto template xml.
…ename to "TN_...".
MichaelLueken
approved these changes
Feb 9, 2023
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
@gsketefian These changes look good to me!
JeffBeck-NOAA
approved these changes
Feb 9, 2023
Collaborator
|
@gsketefian The issues from Jenkins are due to the fact that I had to manually abort the Hera tests (even though the Hera tests are shut off in the Jenkinsfile). All tests have successfully passed the Jenkins tests, so I will now move forward with merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
To be consistent with the naming convention used for variables that specify per-task properties (e.g.
PPN_RUN_FCST,WTIME_RUN_FCST,MAXTRIES_RUN_FCST), rename variables that store the task names (e.g.RUN_FCST_TN) so that the "TN" part is at the beginning, e.g.TN_RUN_FCST.This PR is part of a series to enhance the verification capabilities of the SRW App.
Type of change
TESTS CONDUCTED:
The following fundamental tests were run on Hera using the Intel compiler. All were successful.
From
fundamental.hera.gnu.comand/orfundamental.hera.intel.nco:MET_ensemble_verificationMET_verificationMET_verification_only_vxcommunity_ensemble_2memscommunity_ensemble_2mems_stochgrid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmpgrid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional_plotgrid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRRgrid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRRgrid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1betapregen_grid_orog_sfc_climoFrom previous versions of
fundamental.hera.gnu.comand/orfundamental.hera.intel.nco:grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRRgrid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1betanco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRRDOCUMENTATION:
The documentation has been updated to reflect the changes in the PR.
ISSUE:
Resolves issue #599.
CHECKLIST
N/A
N/A