[develop] Fix failing unit test due to renamed variable#583
Merged
MichaelLueken merged 1 commit intoFeb 7, 2023
Merged
Conversation
JeffBeck-NOAA
approved these changes
Feb 7, 2023
MichaelLueken
approved these changes
Feb 7, 2023
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
Thanks for correcting this so fast, @mkavulich! The unit test is now passing, so I'm approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
PR #566 changed the variable "MODEL" to a more descriptive name, but failed to make this change in
config.community.yaml. The unit tests forgenerate_FV3LAM_wflow.pymake use of this file as an input config.yaml, so they are now failing due to this incorrect variable name. This wasn't caught because prior to #558 the unit tests were broken for a different reason.This change simply makes the appropriate rename, which should fix the failing unit test. Also created an f-string that was missed in a setup.py error message.
Type of change
TESTS CONDUCTED:
This change only impacts the unit tests or other uses of
config.community.yaml, so all tests should pass. Out of an abundance of caution, running fundamental tests on Jet (Hera is down today).DEPENDENCIES:
None
DOCUMENTATION:
None
ISSUE:
None
CHECKLIST