[develop] Fix plotting bug.

[danielabdi-noaa]

DESCRIPTION OF CHANGES:

Fixes issue #527. The fix is applied to setup.py by updating the dictionary value of POST_OUTPUT_DOMAIN_NAME to be lowercase. Currently an uppercase name is writtern to var_defns.sh which is what is causing the problem. It was also possible to fix it by modifying the plotting scripts not to change cases, but I think grib file names with all lowercase letters is desirable so I decided to change setup.py instead.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

TESTS CONDUCTED:

• hera.intel
  grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional_plot
• orion.intel
• cheyenne.intel
• cheyenne.gnu
• gaea.intel
• jet.intel
• wcoss2.intel
• NOAA Cloud (indicate which platform)
• Jenkins
• fundamental test suite
• comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

DOCUMENTATION:

ISSUE:

• Plot_allvars task goes DEAD due to case mismatch #527

CHECKLIST

• My code follows the style guidelines in the Contributor's Guide
• I have performed a self-review of my own code using the Code Reviewer's Guide
• I have commented my code, particularly in hard-to-understand areas
• My changes need updates to the documentation. I have made corresponding changes to the documentation
• My changes do not require updates to the documentation (explain).
• My changes generate no new warnings
• New and existing tests pass with my changes
• Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

• Work In Progress
• bug
• enhancement
• documentation
• release
• high priority
• run_ci
• run_we2e_fundamental_tests
• run_we2e_comprehensive_tests
• Needs Cheyenne test
• Needs Jet test
• Needs Hera test
• Needs Orion test
• help wanted

CONTRIBUTORS (optional):

[MichaelLueken]

@danielabdi-noaa Thanks for addressing the plotting task issue so quickly! I have been able to run the grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional_plot test on Jet and Hera without issue. Do you think it would be a good idea to add this test to one of the fundamental test suites to ensure that this doesn't happen again?

[danielabdi-noaa]

@MichaelLueken Good idea. I think the fundamental.hera.intel.nco has the same test case without plotting so we can replace that with the one that does plotting. It will be testing it in NCO mode though, which should work but probably better to test community mode instead. Or we can add the "community" version of the plotting to some other machine that is not doing a lot of work or modify an existing test case to do plotting without adding a new one.

[MichaelLueken]

@danielabdi-noaa Could we remove the non-plotting test from fundamental.hera.intel.nco and add the plotting test to fundamental.hera.gnu.com? This way, the test is still being done on Hera and with the "community" version.

[danielabdi-noaa]

@MichaelLueken Yes, as it turns out the GNU fundamental test on hera also had that test case so I changed both to test _plot test case so that we test plotting both in community and nco modes.

[MichaelLueken]

@danielabdi-noaa Great! I have gone ahead and submitted the Jenkins tests.

[gspetro-NOAA]

The plotting runs without a glitch on Jet and AWS!