Skip to content

[develop] Add gfs_v16.3 to file list of HPSS for FV3GFS #510

Merged
MichaelLueken merged 2 commits into
ufs-community:developfrom
chan-hoo:feature/gfsv163
Dec 14, 2022
Merged

[develop] Add gfs_v16.3 to file list of HPSS for FV3GFS #510
MichaelLueken merged 2 commits into
ufs-community:developfrom
chan-hoo:feature/gfsv163

Conversation

@chan-hoo

Copy link
Copy Markdown
Collaborator

DESCRIPTION OF CHANGES:

  • The file name of FV3GFS data on HPSS has been changed to v16.3 since 11/29/2022. Therefore, a new file name is added to the list of the file names on HPSS.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • WE2E test nco_grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_timeoffset_suite_GFS_v16 with a new date 2022120612.

  • hera.intel

  • orion.intel

  • cheyenne.intel

  • cheyenne.gnu

  • gaea.intel

  • jet.intel

  • wcoss2.intel

  • NOAA Cloud (indicate which platform)

  • Jenkins

  • fundamental test suite

  • comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes issue mentioned in #509

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Comment thread parm/data_locations.yml
- /NCEPPROD/hpssprod/runhistory/rh{yyyy}/{yyyymm}/{yyyymmdd}
- /NCEPPROD/hpssprod/runhistory/rh{yyyy}/{yyyymm}/{yyyymmdd}
- /NCEPPROD/hpssprod/runhistory/rh{yyyy}/{yyyymm}/{yyyymmdd}
- /NCEPPROD/hpssprod/runhistory/rh{yyyy}/{yyyymm}/{yyyymmdd}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why is this line repeated?

@chan-hoo chan-hoo Dec 12, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffBeck-NOAA, in the current structure of ush/retrieve_data.py, each archive_file_names line requires the corresponding line in the archive_path. @christinaholtNOAA or @danielabdi-noaa may have an answer to this.

@panll panll left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Dec 12, 2022
@MichaelLueken MichaelLueken linked an issue Dec 12, 2022 that may be closed by this pull request

@MichaelLueken MichaelLueken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chan-hoo The nco_grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_timeoffset_suite_GFS_v16 test was run on Hera with the new date, 2022120612. The test successfully passed. Approving these changes.

@MichaelLueken MichaelLueken merged commit bea3633 into ufs-community:develop Dec 14, 2022
@chan-hoo chan-hoo deleted the feature/gfsv163 branch January 12, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FV3GFS data for 2022 December are not retrieved from HPSS

4 participants