[develop] Remove Slurm Memory Option for noaacloud#506
Merged
MichaelLueken merged 1 commit intoDec 6, 2022
Merged
Conversation
danielabdi-noaa
approved these changes
Dec 6, 2022
MichaelLueken
approved these changes
Dec 6, 2022
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
@EdwardSnyder-NOAA These changes look good to me! Tests were run on Gaea to ensure continued functionality. All tests passed successfully. Approving now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Added logic to not include the slurm memory option for our NOAA cloud platforms. Testing the development branch of the SRW App on NOAA cloud platforms revealed this error:
"FV3LAM_wflow.xml :: sbatch: error: Memory specification can not be satisfied"
Slurm on NOAA cloud wasn't setup like the rest of the RDHPCs, so there isn't a good way to configure its memory. Removing the slurm memory option allows for the experiment to complete successfully.
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
The slurm memory logic was reported in Issue #349 and was addressed in PR #443.
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):
Discussed with @danielabdi-noaa the origins of the Issue and PR.