[develop] Ensure arbitrary restart_interval numbers in model_configure#503
Conversation
|
@MichaelLueken, Thank you! I forgot to add [develop] to the title. |
MichaelLueken
left a comment
There was a problem hiding this comment.
@chan-hoo These changes look good to me. However, the specify_RESTART_INTERVAL WE2E test was ran on Cheyenne. This test failed due to running over the walltime limit. Please increase WTIME_RUN_FCST: to allow the test to run on this machine (01:30:00 or 02:00:00 should allow this test to run to completion).
MichaelLueken
left a comment
There was a problem hiding this comment.
Thank you very much, @chan-hoo, for addressing my concern! A rerun of the specify_RESTART_INTERVAL test on Cheyenne is now successfully passing. Approving this work and launching the Jenkins tests.
danielabdi-noaa
left a comment
There was a problem hiding this comment.
I have run the test case modified in this PR on Hera, and it does produce restart files for forecast hours 1, 2 and 5 so approving.
|
The Jenkins tests have passed, two approvals have been given, and there are no outstanding comments, so I will now move forward with merging this work. |
DESCRIPTION OF CHANGES:
restart_interval, the unnecessary parameter value-1is removed from the templateparm/model_configure.restart_interval: 1 2 5, which creates the restart files at fhr=1, 2, and 5.Type of change
TESTS CONDUCTED:
ISSUE:
Fixes issue mentioned in #502
CHECKLIST