Skip to content

[develop] Update ufs-weather-model hash and add WoFS_v0 to suites and tests#492

Merged
MichaelLueken merged 1 commit into
ufs-community:developfrom
MichaelLueken:feature/update-ufs-wm-WoFS
Nov 30, 2022
Merged

[develop] Update ufs-weather-model hash and add WoFS_v0 to suites and tests#492
MichaelLueken merged 1 commit into
ufs-community:developfrom
MichaelLueken:feature/update-ufs-wm-WoFS

Conversation

@MichaelLueken
Copy link
Copy Markdown
Collaborator

@MichaelLueken MichaelLueken commented Nov 18, 2022

DESCRIPTION OF CHANGES:

The ufs-weather-model hash was updated in the release/public-v2.1.0 branch to 84b28ec. This hash brings in the WoFS_v0 SDF. This PR will update the ufs-weather-model hash to 84b28ec in the authoritative develop branch and bring in the components for developers to use the WoFS_v0 SDF.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
    @gspetro-NOAA has already updated the documentation in develop, noting that WoFS_v0 is a currently supported CCPP parameter.
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@MichaelLueken MichaelLueken added ci-hera-intel-WE Kicks off automated workflow test on hera with intel ci-jet-intel-WE Kicks off automated workflow test on jet with intel labels Nov 18, 2022
@venitahagerty venitahagerty removed ci-jet-intel-WE Kicks off automated workflow test on jet with intel ci-hera-intel-WE Kicks off automated workflow test on hera with intel labels Nov 18, 2022
@venitahagerty
Copy link
Copy Markdown
Collaborator

venitahagerty commented Nov 18, 2022 •
edited
Loading

Machine: hera
Compiler: intel
Job: WE
Repo location: /scratch1/BMC/zrtrr/rrfs_ci/autoci/pr/1128154471/20221118203510/ufs-srweather-app
Build was Successful
Rocoto jobs started
Long term tracking will be done on 10 experiments
If test failed, please make changes and add the following label back:
ci-hera-intel-WE
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
Experiment Succeeded on hera: pregen_grid_orog_sfc_climo
Experiment Succeeded on hera: community_ensemble_2mems_stoch
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: MET_ensemble_verification
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
All experiments completed

@venitahagerty
Copy link
Copy Markdown
Collaborator

venitahagerty commented Nov 18, 2022 •
edited
Loading

Machine: jet
Compiler: intel
Job: WE
Repo location: /lfs1/BMC/nrtrr/rrfs_ci/autoci/pr/1128154471/20221118203509/ufs-srweather-app
Build was Successful
Rocoto jobs started
Long term tracking will be done on 10 experiments
If test failed, please make changes and add the following label back:
ci-jet-intel-WE
Experiment Succeeded on jet: nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on jet: specify_DT_ATMOS_LAYOUT_XY_BLOCKSIZE
Experiment Succeeded on jet: custom_ESGgrid
Experiment Succeeded on jet: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
Experiment Succeeded on jet: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
Experiment Succeeded on jet: custom_GFDLgrid
Experiment Succeeded on jet: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
Experiment Succeeded on jet: specify_RESTART_INTERVAL
Experiment Succeeded on jet: specify_DOT_OR_USCORE
Experiment Succeeded on jet: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
All experiments completed

danielabdi-noaa
danielabdi-noaa reviewed Nov 19, 2022
View reviewed changes
Comment thread sorc/CMakeLists.txt Outdated
# Build UFS weather model
if (BUILD_UFS)
list(APPEND TARGET_LIST ufs-weather-model)
list(APPEND TARGET_LIST UFS)
Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa Nov 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelLueken This needs to be removved because it will re-introduce the bug with building without installing the ufs-weather-model.

Comment thread ...xtrn_mdls_suites_community/config.grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0.yaml Outdated
EXTRN_MDL_FILES_LBCS:
- '{yy}{jjj}{hh}00{fcst_hr:02d}00'
task_run_fcst:
PREDEF_GRID_NAME: SUBCONUS_Ind_3km
Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa Nov 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PREDEF_GRID_NAME should be in workflow: section after CCPP_PHYS_SUITE:, and then remove the task_run_fcst section.

Comment thread ...mdls_suites_community/config.grid_SUBCONUS_Ind_3km_ics_FV3GFS_lbcs_FV3GFS_suite_WoFS_v0.yaml Outdated
FV3GFS_FILE_FMT_LBCS: grib2
USE_USER_STAGED_EXTRN_FILES: true
task_run_fcst:
PREDEF_GRID_NAME: SUBCONUS_Ind_3km
Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa Nov 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

@MichaelLueken MichaelLueken force-pushed the feature/update-ufs-wm-WoFS branch from 1769b7a to effa409 Compare November 21, 2022 14:34
@MichaelLueken MichaelLueken marked this pull request as ready for review November 21, 2022 14:35
@MichaelLueken
Copy link
Copy Markdown
Collaborator Author

MichaelLueken commented Nov 21, 2022

@danielabdi-noaa Thank you very much for the review! I have updated the three files. Please let me know if you see anything else that needs to be addressed. Thanks!

danielabdi-noaa
danielabdi-noaa approved these changes Nov 21, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Nov 21, 2022
@MichaelLueken
Copy link
Copy Markdown
Collaborator Author

MichaelLueken commented Nov 29, 2022

With the merging of PR #498 this morning, it is even more imperative that this work be reviewed and merged. The current develop doesn't have the necessary ufs-weather-model hash to use WoFS_v0, nor the necessary changes to files to utilize the new WoFS_v0 SDF. Please take a moment to review this work so that the necessary components to use WoFS_v0 are available in develop. Thanks!

@MichaelLueken MichaelLueken merged commit 4a9d1fe into ufs-community:develop Nov 30, 2022
@MichaelLueken MichaelLueken deleted the feature/update-ufs-wm-WoFS branch November 30, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielabdi-noaa danielabdi-noaa danielabdi-noaa approved these changes

@JeffBeck-NOAA JeffBeck-NOAA JeffBeck-NOAA approved these changes

@mkavulich mkavulich Awaiting requested review from mkavulich

@gsketefian gsketefian Awaiting requested review from gsketefian gsketefian is a code owner

@RatkoVasic-NOAA RatkoVasic-NOAA Awaiting requested review from RatkoVasic-NOAA RatkoVasic-NOAA is a code owner

@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA

@ywangwof ywangwof Awaiting requested review from ywangwof ywangwof is a code owner

@chan-hoo chan-hoo Awaiting requested review from chan-hoo chan-hoo is a code owner

@panll panll Awaiting requested review from panll panll is a code owner

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@christopherwharrop-noaa christopherwharrop-noaa Awaiting requested review from christopherwharrop-noaa

@mark-a-potts mark-a-potts Awaiting requested review from mark-a-potts

@jkbk2004 jkbk2004 Awaiting requested review from jkbk2004 jkbk2004 is a code owner

@willmayfield willmayfield Awaiting requested review from willmayfield

@dmwright526 dmwright526 Awaiting requested review from dmwright526

@gspetro-NOAA gspetro-NOAA Awaiting requested review from gspetro-NOAA gspetro-NOAA is a code owner

@natalie-perlin natalie-perlin Awaiting requested review from natalie-perlin natalie-perlin is a code owner

@EdwardSnyder-NOAA EdwardSnyder-NOAA Awaiting requested review from EdwardSnyder-NOAA EdwardSnyder-NOAA is a code owner

Assignees

No one assigned

Labels

run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MichaelLueken @venitahagerty @danielabdi-noaa @JeffBeck-NOAA