[release/public-v2.1.0] Plotting script fix: correct a variable name to a lower-case#472
Merged
MichaelLueken merged 1 commit intoNov 14, 2022
Conversation
JeffBeck-NOAA
approved these changes
Nov 13, 2022
MichaelLueken
approved these changes
Nov 14, 2022
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
The following was added by Bruce Kropp in the Jenkins configuration file on all platforms:
sed -i 's/Geopotential Height/Geopotential height/g' ./ush/Python/plot_allvars.py
This is done so the plotting script can run via Jenkins. It'll fail because the height in GH is now lower case. It sounds like there was a change in how the NetCDF file displays GH and the proper changes didn't make into the plotting script.
This update corrects the inconsistency in Geopotential height for plot_allvars.py, so approving this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB: Correction similar to a PR-468 for a develop branch
DESCRIPTION OF CHANGES:
Running plotting script throws an error when new miniconda/python are used.
The fix is to use the lower-case name of the one of the plotted variables.
The fix originally found and applied by @EdwardSnyder-NOAA , tested by
@BruceKropp-Raytheon . The fix was limited to applying it using "sed" at the time of plotting.
Type of change
TESTS CONDUCTED:
@BruceKropp-Raytheon was performing testing
DEPENDENCIES:
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):
@EdwardSnyder-NOAA @BruceKropp-Raytheon @gspetro-NOAA