Skip to content

[release/public-v2.1.0] Plotting script fix: correct a variable name to a lower-case#472

Merged
MichaelLueken merged 1 commit into
ufs-community:release/public-v2.1.0from
natalie-perlin:release/public-v2.1.0_plotting
Nov 14, 2022
Merged

[release/public-v2.1.0] Plotting script fix: correct a variable name to a lower-case#472
MichaelLueken merged 1 commit into
ufs-community:release/public-v2.1.0from
natalie-perlin:release/public-v2.1.0_plotting

Conversation

@natalie-perlin
Copy link
Copy Markdown
Collaborator

NB: Correction similar to a PR-468 for a develop branch

DESCRIPTION OF CHANGES:

Running plotting script throws an error when new miniconda/python are used.
The fix is to use the lower-case name of the one of the plotted variables.

The fix originally found and applied by @EdwardSnyder-NOAA , tested by
@BruceKropp-Raytheon . The fix was limited to applying it using "sed" at the time of plotting.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

TESTS CONDUCTED:

@BruceKropp-Raytheon was performing testing

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins

DEPENDENCIES:

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test

CONTRIBUTORS (optional):

@EdwardSnyder-NOAA @BruceKropp-Raytheon @gspetro-NOAA

Copy link
Copy Markdown
Collaborator

@panll panll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MichaelLueken MichaelLueken added bug Something isn't working release This PR/issue is related to a release branch labels Nov 14, 2022
Copy link
Copy Markdown
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following was added by Bruce Kropp in the Jenkins configuration file on all platforms:

sed -i 's/Geopotential Height/Geopotential height/g' ./ush/Python/plot_allvars.py

This is done so the plotting script can run via Jenkins. It'll fail because the height in GH is now lower case. It sounds like there was a change in how the NetCDF file displays GH and the proper changes didn't make into the plotting script.

This update corrects the inconsistency in Geopotential height for plot_allvars.py, so approving this PR.

@MichaelLueken MichaelLueken changed the title Plotting script fix: correct a variable name to a lower-case [release/public-v2.1.0] Plotting script fix: correct a variable name to a lower-case Nov 14, 2022
@MichaelLueken MichaelLueken merged commit 239b8cd into ufs-community:release/public-v2.1.0 Nov 14, 2022
@natalie-perlin natalie-perlin deleted the release/public-v2.1.0_plotting branch December 1, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release This PR/issue is related to a release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants