[Release 2.1.0] Updated files to add WoFS to suites and tests#447
Merged
mark-a-potts merged 1 commit intoNov 2, 2022
Merged
Conversation
natalie-perlin
approved these changes
Nov 2, 2022
Collaborator
|
@mark-a-potts, will this PR also be opened in the develop branch? Thanks! |
Contributor
Author
|
@JeffBeck-NOAA It will only work on develop once the WM has been updated there. Are we ready to update that on the develop branch? |
Collaborator
|
@mark-a-potts, since it was merged as part of this and this PR, it should be OK to add to our develop branch. |
Contributor
Author
|
@JeffBeck-NOAA I meant that the hash to the WM in Externals.cfg needs to be updated in the develop branch of the ufs-srweather-app repo before the WoFS tests will work. We can update it and add in the tests to develop, if you think we are ready for that. |
Collaborator
|
@mark-a-potts, oh, OK! Yes, I think we can probably do that. It's obviously not urgent, and the release is currently the focus, so we can certainly wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Type of change
TESTS CONDUCTED:
DOCUMENTATION:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR: