Skip to content

Set agent in matrix block instead of child stages#441

Merged
MichaelLueken merged 1 commit into
ufs-community:developfrom
jessemcfarland:bugfix/jenkinsfile_workspaces
Oct 31, 2022
Merged

Set agent in matrix block instead of child stages#441
MichaelLueken merged 1 commit into
ufs-community:developfrom
jessemcfarland:bugfix/jenkinsfile_workspaces

Conversation

@jessemcfarland
Copy link
Copy Markdown
Collaborator

@jessemcfarland jessemcfarland commented Oct 28, 2022

DESCRIPTION OF CHANGES:

Set agent in matrix block instead of child stages to ensure the same agent is used for each child stage.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

Copy link
Copy Markdown
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the agent declaration outside of the stage sections has corrected the issues that were being encountered with the Jenkins CI tests on Cheyenne on Friday. Approving these changes.

Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is important so approving.

@MichaelLueken MichaelLueken merged commit 6033ba6 into ufs-community:develop Oct 31, 2022
@jessemcfarland jessemcfarland deleted the bugfix/jenkinsfile_workspaces branch November 1, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants