Bug fix on hera/jet run_vx.local modulefile.#438
Merged
danielabdi-noaa merged 2 commits intoOct 29, 2022
Conversation
MichaelLueken
approved these changes
Oct 28, 2022
Collaborator
MichaelLueken
left a comment
There was a problem hiding this comment.
@danielabdi-noaa Looks good! Thanks for correcting the spelling os.getenv for hera and jet's run_vx.local modulefiles. Also, thanks for removing the SFC_CLIMO_FIELDS entries from ush/config_defaults.yaml (since they were added to parm/fixed_files_mapping.yaml during the work from #421). You also made an excellent point about either adding a verification test to the fundamental tests or running the comprehensive tests on a regular basis on develop. Approving these changes.
natalie-perlin
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
There is a typo in
run_vx.local.luamodulefiles of Hera and Jet that results in verification tests failing.Issue described in
The fundamental test did not have a verification test included so this bug is missed for a couple of days.
Maybe time to expand the fundamental tests a bit, or run the comprehensive Jenkins tests from time to time?
Type of change
TESTS CONDUCTED:
Run
MET_ensemble_verificationsuccessfullyDEPENDENCIES:
None
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):