Skip to content

Bug fix on hera/jet run_vx.local modulefile.#438

Merged
danielabdi-noaa merged 2 commits into
ufs-community:developfrom
danielabdi-noaa:bugfix/vx_module
Oct 29, 2022
Merged

Bug fix on hera/jet run_vx.local modulefile.#438
danielabdi-noaa merged 2 commits into
ufs-community:developfrom
danielabdi-noaa:bugfix/vx_module

Conversation

@danielabdi-noaa
Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa commented Oct 28, 2022

DESCRIPTION OF CHANGES:

There is a typo in run_vx.local.lua modulefiles of Hera and Jet that results in verification tests failing.

Issue described in

The fundamental test did not have a verification test included so this bug is missed for a couple of days.
Maybe time to expand the fundamental tests a bit, or run the comprehensive Jenkins tests from time to time?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
    Run MET_ensemble_verification successfully
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

None

DOCUMENTATION:

ISSUE:

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

CONTRIBUTORS (optional):

Copy link
Copy Markdown
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielabdi-noaa Looks good! Thanks for correcting the spelling os.getenv for hera and jet's run_vx.local modulefiles. Also, thanks for removing the SFC_CLIMO_FIELDS entries from ush/config_defaults.yaml (since they were added to parm/fixed_files_mapping.yaml during the work from #421). You also made an excellent point about either adding a verification test to the fundamental tests or running the comprehensive tests on a regular basis on develop. Approving these changes.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Oct 28, 2022
@danielabdi-noaa danielabdi-noaa merged commit 2f8bd26 into ufs-community:develop Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Priority: HIGH run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants