Skip to content

[develop] Remove my_load_any from modulefiles/srw_common.lua and use load_any#434

Merged
MichaelLueken merged 1 commit into
ufs-community:developfrom
MichaelLueken:feature/remove-my-load-any
Oct 28, 2022
Merged

[develop] Remove my_load_any from modulefiles/srw_common.lua and use load_any#434
MichaelLueken merged 1 commit into
ufs-community:developfrom
MichaelLueken:feature/remove-my-load-any

Conversation

@MichaelLueken
Copy link
Copy Markdown
Collaborator

@MichaelLueken MichaelLueken commented Oct 27, 2022

DESCRIPTION OF CHANGES:

Following Cheyenne's maintenance, it was noted that the version of Lmod available was updated from 8.1.7 to 8.7.13. An Lmod version >= 8.3.7 is required to use Lmod's load_any function. A workaround was implemented when converting the modulefiles from TCL to Lua. Now that Lmod 8.7.13 is available, there is no longer a need for the my_load_any workaround solution. This work removes the my_load_any function from modulefiles/srw_common.lua and uses load_any instead.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

TESTS CONDUCTED:

The fundamental WE2E tests were run on Hera and Cheyenne (both Intel and GNU).

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes #429

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

CONTRIBUTORS (optional):

@danielabdi-noaa and @christopherwharrop-noaa provided valuable insight with respect to issues encountered with loading the modulefiles/build_cheyenne_intel.lua modulefile.

@MichaelLueken
Issue ufs-community#429 - Removed my_load_any function from modulefil…
dbad22d 
…es/srw_common.lua, replace my_load_any with load_any in modulefiles/srw_common.lua, and removed load(pathJoin(mapl, os.getenv(mapl_ver) or 2.11.0-esmf-8.3.0b09)) from modulefiles/build_cheyenne_intel.lua so that the SRW would build with Intel compilers.
@MichaelLueken MichaelLueken added ci-hera-intel-WE Kicks off automated workflow test on hera with intel ci-jet-intel-WE Kicks off automated workflow test on jet with intel labels Oct 27, 2022
@venitahagerty venitahagerty removed ci-hera-intel-WE Kicks off automated workflow test on hera with intel ci-jet-intel-WE Kicks off automated workflow test on jet with intel labels Oct 27, 2022
@venitahagerty
Copy link
Copy Markdown
Collaborator

venitahagerty commented Oct 27, 2022 •
edited
Loading

Machine: hera
Compiler: intel
Job: WE
Repo location: /scratch1/BMC/zrtrr/rrfs_ci/autoci/pr/1101633718/20221027125011/ufs-srweather-app
Build was Successful
Rocoto jobs started
Long term tracking will be done on 9 experiments
If test failed, please make changes and add the following label back:
ci-hera-intel-WE
Experiment Succeeded on hera: nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
All experiments completed

danielabdi-noaa
danielabdi-noaa approved these changes Oct 27, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Oct 27, 2022
@venitahagerty
Copy link
Copy Markdown
Collaborator

venitahagerty commented Oct 27, 2022 •
edited
Loading

Machine: jet
Compiler: intel
Job: WE
Repo location: /lfs1/BMC/nrtrr/rrfs_ci/autoci/pr/1101633718/20221027125018/ufs-srweather-app
Build was Successful
Rocoto jobs started
Long term tracking will be done on 9 experiments
If test failed, please make changes and add the following label back:
ci-jet-intel-WE
Experiment Failed on jet: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
2022-10-27 13:28:07 +0000 :: fe2 :: Task get_extrn_lbcs, jobid=14816839, in state DEAD (OUT_OF_MEMORY), ran for 217.0 seconds, exit status=253, try=1 (of 1)
Experiment Succeeded on jet: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
Experiment Succeeded on jet: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
Experiment Succeeded on jet: nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on jet: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
Experiment Succeeded on jet: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on jet: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
Experiment Succeeded on jet: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
Experiment Succeeded on jet: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
All experiments completed

@MichaelLueken MichaelLueken added the ci-jet-intel-WE Kicks off automated workflow test on jet with intel label Oct 27, 2022
@venitahagerty venitahagerty removed the ci-jet-intel-WE Kicks off automated workflow test on jet with intel label Oct 27, 2022
@venitahagerty
Copy link
Copy Markdown
Collaborator

venitahagerty commented Oct 27, 2022 •
edited
Loading

Machine: jet
Compiler: intel
Job: WE
Repo location: /lfs1/BMC/nrtrr/rrfs_ci/autoci/pr/1101633718/20221027172010/ufs-srweather-app
Build was Successful
Rocoto jobs started
Long term tracking will be done on 9 experiments
If test failed, please make changes and add the following label back:
ci-jet-intel-WE
Experiment Failed on jet: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
2022-10-27 18:00:11 +0000 :: fe2 :: Task get_extrn_lbcs, jobid=14831568, in state DEAD (OUT_OF_MEMORY), ran for 163.0 seconds, exit status=253, try=1 (of 1)
Experiment Failed on jet: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
2022-10-27 18:00:09 +0000 :: fe3 :: Task get_extrn_lbcs, jobid=14831563, in state DEAD (OUT_OF_MEMORY), ran for 144.0 seconds, exit status=253, try=1 (of 1)
Experiment Succeeded on jet: nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on jet: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
Experiment Succeeded on jet: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
Experiment Succeeded on jet: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on jet: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
Experiment Succeeded on jet: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
Experiment Succeeded on jet: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
All experiments completed

natalie-perlin
natalie-perlin approved these changes Oct 28, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@natalie-perlin natalie-perlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes on Cheyenne, modules load properly.

@MichaelLueken MichaelLueken merged commit 16ad699 into ufs-community:develop Oct 28, 2022
@MichaelLueken MichaelLueken deleted the feature/remove-my-load-any branch October 28, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielabdi-noaa danielabdi-noaa danielabdi-noaa approved these changes

@natalie-perlin natalie-perlin natalie-perlin approved these changes

@mkavulich mkavulich Awaiting requested review from mkavulich

@gsketefian gsketefian Awaiting requested review from gsketefian gsketefian is a code owner

@JeffBeck-NOAA JeffBeck-NOAA Awaiting requested review from JeffBeck-NOAA JeffBeck-NOAA is a code owner

@RatkoVasic-NOAA RatkoVasic-NOAA Awaiting requested review from RatkoVasic-NOAA RatkoVasic-NOAA is a code owner

@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA

@ywangwof ywangwof Awaiting requested review from ywangwof ywangwof is a code owner

@chan-hoo chan-hoo Awaiting requested review from chan-hoo chan-hoo is a code owner

@panll panll Awaiting requested review from panll panll is a code owner

@christinaholtNOAA christinaholtNOAA Awaiting requested review from christinaholtNOAA christinaholtNOAA is a code owner

@christopherwharrop-noaa christopherwharrop-noaa Awaiting requested review from christopherwharrop-noaa

@mark-a-potts mark-a-potts Awaiting requested review from mark-a-potts

@jkbk2004 jkbk2004 Awaiting requested review from jkbk2004 jkbk2004 is a code owner

@willmayfield willmayfield Awaiting requested review from willmayfield

@dmwright526 dmwright526 Awaiting requested review from dmwright526

@gspetro-NOAA gspetro-NOAA Awaiting requested review from gspetro-NOAA gspetro-NOAA is a code owner

@EdwardSnyder-NOAA EdwardSnyder-NOAA Awaiting requested review from EdwardSnyder-NOAA EdwardSnyder-NOAA is a code owner

Assignees

No one assigned

Labels

run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove my_load_any from modulefiles/srw_common.lua and use load_any

4 participants

@MichaelLueken @venitahagerty @danielabdi-noaa @natalie-perlin