Skip to content

Post merge cleanup: remove old script, consolidate test directories#430

Merged
MichaelLueken merged 5 commits into
ufs-community:developfrom
mkavulich:feature/issue_351_post_merge_cleanup
Oct 26, 2022
Merged

Post merge cleanup: remove old script, consolidate test directories#430
MichaelLueken merged 5 commits into
ufs-community:developfrom
mkavulich:feature/issue_351_post_merge_cleanup

Conversation

@mkavulich
Copy link
Copy Markdown
Collaborator

DESCRIPTION OF CHANGES:

Some cleanup after the merger of the old regional_workflow repository: eliminate the outdated update_fork.pl, and move test script and readme from test/ to tests/ directory.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

TESTS CONDUCTED:

  • cheyenne.intel
    • used build.sh to build app
    • fundamental test suite (pending)
  • Jenkins

DEPENDENCIES:

CI testing will have to be updated to account for the new location of build.sh. I have corresponded with @venitahagerty and @danielabdi-noaa to make sure they are in the loop and can apply the appropriate changes.

DOCUMENTATION:

None

ISSUE:

Addresses a few items from #351

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@danielabdi-noaa
Copy link
Copy Markdown
Collaborator

@mkavulich I think only a one line change is required to get Jenkins build working so you may as well make it in this PR.
In .cicd/scripts/srw_build.sh

 # Build and install
-cd ${workspace}/test
+cd ${workspace}/tests

@venitahagerty venitahagerty added ci-hera-intel-build Kicks off automated build test on hera with intel and removed ci-hera-intel-build Kicks off automated build test on hera with intel labels Oct 25, 2022
@venitahagerty
Copy link
Copy Markdown
Collaborator

Machine: hera
Compiler: intel
Job: build
Repo location: /scratch1/BMC/zrtrr/rrfs_ci/autoci/pr/1099467489/20221025213515/ufs-srweather-app
Build was Successful
If test failed, please make changes and add the following label back:
ci-hera-intel-build

@mkavulich
Copy link
Copy Markdown
Collaborator Author

@danielabdi-noaa Thanks for the tip! I missed that in my search for references to the build script, I have implemented that change.

Copy link
Copy Markdown
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkavulich These changes look good! I approve these changes.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Oct 26, 2022
@venitahagerty venitahagerty added ci-jet-intel-build Kicks off automated build test on jet with gnu and removed ci-jet-intel-build Kicks off automated build test on jet with gnu labels Oct 26, 2022
@venitahagerty
Copy link
Copy Markdown
Collaborator

Machine: jet
Compiler: intel
Job: build
Repo location: /lfs1/BMC/nrtrr/rrfs_ci/autoci/pr/1099467489/20221026145011/ufs-srweather-app
Build was Successful
If test failed, please make changes and add the following label back:
ci-jet-intel-build

@MichaelLueken
Copy link
Copy Markdown
Collaborator

The CI build tests on Hera and Jet successfully passed. The Jenkins CI pipeline also successfully passed all build and fundamental testing. Now merging to authoritative repository.

@MichaelLueken MichaelLueken merged commit 0ce31b4 into ufs-community:develop Oct 26, 2022
@mkavulich mkavulich deleted the feature/issue_351_post_merge_cleanup branch July 19, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants