Skip to content

Restore correct conda activate message for Cheyenne#424

Merged
MichaelLueken merged 1 commit into
developfrom
mkavulich-patch-1
Oct 24, 2022
Merged

Restore correct conda activate message for Cheyenne#424
MichaelLueken merged 1 commit into
developfrom
mkavulich-patch-1

Conversation

@mkavulich
Copy link
Copy Markdown
Collaborator

@mkavulich mkavulich commented Oct 21, 2022

DESCRIPTION OF CHANGES:

PR #413 inadvertently modified the conda activate message printed to screen for Cheyenne. Unlike NOAA RDHPC platforms, Cheyenne requires the full path to the conda environment to activate properly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

TESTS CONDUCTED:

  • cheyenne.intel
    • Loaded module, confirmed correct message is now printed

This is a print-only change, but have kicked off automated tests on Hera and Jet out of an abundance of caution.

DEPENDENCIES:

None

DOCUMENTATION:

Self-documenting

ISSUE:

None

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Restore correct `conda activate` message for Cheyenne
@mkavulich mkavulich added ci-hera-intel-WE Kicks off automated workflow test on hera with intel ci-jet-intel-WE Kicks off automated workflow test on jet with intel labels Oct 21, 2022
@venitahagerty venitahagerty removed the ci-jet-intel-WE Kicks off automated workflow test on jet with intel label Oct 21, 2022
@venitahagerty
Copy link
Copy Markdown
Collaborator

Machine: jet
Compiler: intel
Job: WE
Repo location: /lfs1/BMC/nrtrr/rrfs_ci/autoci/pr/1095815932/20221021222014/ufs-srweather-app
If test failed, please make changes and add the following label back:
ci-jet-intel-WE

@venitahagerty venitahagerty removed the ci-hera-intel-WE Kicks off automated workflow test on hera with intel label Oct 21, 2022
@venitahagerty
Copy link
Copy Markdown
Collaborator

venitahagerty commented Oct 21, 2022

Machine: hera
Compiler: intel
Job: WE
Repo location: /scratch1/BMC/zrtrr/rrfs_ci/autoci/pr/1095815932/20221021222015/ufs-srweather-app
Build was Successful
Rocoto jobs started
Long term tracking will be done on 9 experiments
If test failed, please make changes and add the following label back:
ci-hera-intel-WE
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta
Experiment Succeeded on hera: nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR
Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
All experiments completed

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Oct 24, 2022
@mkavulich
Copy link
Copy Markdown
Collaborator Author

@MichaelLueken Do you know the status of these automated tests? It shows up as "errored" here on github, but checking on disk on Cheyenne it looks like the tests succeeded: /glade/scratch/epicufsrt/jenkins/workspace/fs-srweather-app_pipeline_PR-424__2/

This change is documentation only so it shouldn't result in any failures.

@MichaelLueken
Copy link
Copy Markdown
Collaborator

Visual inspection of the Jenkins CI test results show that all tests on Cheyenne (both Intel and GNU) successfully passed. The tests also successfully passed on Orion, Gaea, and Jet. The tests have stalled out on Hera, but the tests that have been submitted and run have all passed successfully. Merging this work now.

@MichaelLueken MichaelLueken merged commit 9cd91d3 into develop Oct 24, 2022
@MichaelLueken
Copy link
Copy Markdown
Collaborator

@mkavulich It looks like the agents were disconnected for Hera, Orion, and Cheyenne, which ultimately broke the Jenkins automated testing. The experiment directories were checked and all tests had successfully passed on Cheyenne (both Intel and GNU), Orion, Jet, and Gaea. Hera was hanging, but the tests that had been submitted and run successfully completed. Plus, as you noted, this is more of a documentation change (making sure the whole path to the regional_workflow conda environment is specified after loading wflow_cheyenne). So, I have gone ahead and merged your changes.

@mkavulich mkavulich deleted the mkavulich-patch-1 branch February 6, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants