[develop] Make CIs test NCO mode properly.#418
Conversation
|
Machine: hera |
|
Machine: jet |
MichaelLueken
left a comment
There was a problem hiding this comment.
A test on Hera has shown that the "nco" fundamental test is populating the expt_dir/log directory. This is the expected behavior for this PR, so I give my approval.
|
I believe this PR passed fundamental tests on all systems, except on Orion where it failed in 1 test case. |
|
@danielabdi-noaa It appears as though a condition occurred on Orion on Friday that required immediate maintenance. A rerun of the Jenkins pipeline for Orion has successfully passed. All Jenkins-based fundamental tests have now successfully passed. Once a second approval is given, this work will be ready to be merged. |
|
Can someone review this PR? This is a critical piece to have NCO mode enabled in Jenkins, and we already have multiple issues of breaking NCO mode. |
|
@JeffBeck-NOAA Thanks for the review! |
DESCRIPTION OF CHANGES:
This PR addresses issue #416 through the alternative means described there
EXPTDIR/logmaking "nco" mode indistiguishable from "community" mode as far as the CIs are concernedType of change
TESTS CONDUCTED:
Run one test on Hera and Jet successfully in NCO mode and confirmed the EXPTDIR/log is populated with log files.
Test on one system should be enough for this PR.
DEPENDENCIES:
None
DOCUMENTATION:
None required
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):