-
Notifications
You must be signed in to change notification settings - Fork 130
[develop] Deprecate the CYCL_HRS configuration setting. #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e7d2562
19d2adb
d7a6692
6826cfc
4faf867
0c8e3af
a72b5de
7f2277e
36cd708
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,30 @@ | ||
| Test Name,PREDEF_GRID_NAME,CCPP_PHYS_SUITE,EXTRN_MDL_NAME_ICS,EXTRN_MDL_NAME_LBCS,DATES (UTC),CYCL_HRS (UTC),FCST_LEN_HRS (hrs),DT_ATMOS (s) | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please let me know if I should have formatted this one differently with this change. It wasn't clear to me whether this file was autogenerated, or maintained manually. |
||
| grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16,RRFS_CONUS_25km,GFS_v16,FV3GFS,FV3GFS,20190701,0,6,40 | ||
| grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16,RRFS_CONUS_13km,GFS_v16,FV3GFS,FV3GFS,20190701,0,6,45 | ||
| grid_SUBCONUS_Ind_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16,SUBCONUS_Ind_3km,GFS_v16,FV3GFS,FV3GFS,20190615,18,6,40 | ||
| grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta,SUBCONUS_Ind_3km,RRFS_v1beta,HRRR,RAP,20200801,0,6,40 | ||
| grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_HRRR,SUBCONUS_Ind_3km,HRRR,HRRR,RAP,20200810,0,6,40 | ||
| grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0,SUBCONUS_Ind_3km,WoFS,HRRR,RAP,20200801,0,6,40 | ||
| grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16,RRFS_CONUS_3km,GFS_v16,FV3GFS,FV3GFS,20190701,0,6,36 | ||
| grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta,RRFS_CONUScompact_25km,RRFS_v1beta,HRRR,RAP,20200810,0,3,40 | ||
| grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta,RRFS_CONUScompact_13km,RRFS_v1beta,HRRR,RAP,20200801,0,6,45 | ||
| grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta,RRFS_CONUScompact_3km,RRFS_v1beta,HRRR,RAP,20200801,0,6,40 | ||
| grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR,RRFS_CONUScompact_25km,HRRR,HRRR,RAP,20200810,0,6,40 | ||
| grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_HRRR,RRFS_CONUScompact_13km,HRRR,HRRR,RAP,20200810,0,6,45 | ||
| grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_HRRR,RRFS_CONUScompact_3km,HRRR,HRRR,RAP,20200810,0,6,40 | ||
| grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta,RRFS_CONUS_25km,RRFS_v1beta,FV3GFS,FV3GFS,20190701,0,6,40 | ||
| grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR,RRFS_CONUS_25km,HRRR,FV3GFS,FV3GFS,20190701,0,6,40 | ||
| grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta,RRFS_CONUS_13km,RRFS_v1beta,FV3GFS,FV3GFS,20190701,0,6,45 | ||
| grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR,RRFS_CONUS_13km,HRRR,FV3GFS,FV3GFS,20190701,0,6,45 | ||
| grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta,RRFS_CONUS_3km,RRFS_v1beta,FV3GFS,FV3GFS,20190701,0,6,36 | ||
| grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR,RRFS_CONUS_3km,HRRR,FV3GFS,FV3GFS,20190701,0,6,36 | ||
| community_ensemble_008mems,RRFS_CONUS_25km,FV3_GFS_2017_gfdlmp,FV3GFS,FV3GFS,"20190701, 20190702","00,12",6,40 | ||
| community_ensemble_2mems,RRFS_CONUS_25km,FV3_GFS_2017_gfdlmp,FV3GFS,FV3GFS,"20190701, 20190702","00,12",6,40 | ||
| deactivate_tasks,RRFS_CONUS_25km,FV3_GFS_v15p2,FV3GFS,FV3GFS,20190701,0,6,40 | ||
| inline_post,RRFS_CONUS_25km,FV3_GFS_v15p2,FV3GFS,FV3GFS,20190701,0,6,40 | ||
| MET_ensemble_verification,RRFS_CONUS_25km,FV3_GFS_v15p2,FV3GFS,FV3GFS,20190615,0,6,40 | ||
| MET_verification,RRFS_CONUS_25km,FV3_GFS_v15p2,FV3GFS,FV3GFS,20190615,0,6,40 | ||
| custom_ESGgrid,N/A,FV3_GFS_2017_gfdlmp_regional,FV3GFS,FV3GFS,20190701,0,6,40 | ||
| custom_GFDLgrid,N/A,FV3_GFS_2017_gfdlmp,FV3GFS,FV3GFS,20190701,0,6,100 | ||
| custom_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE,N/A,FV3_GFS_2017_gfdlmp,FV3GFS,FV3GFS,20190701,0,6,100 | ||
| custom_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_TRUE,N/A,FV3_GFS_2017_gfdlmp,FV3GFS,FV3GFS,20190701,0,6,100 | ||
| Test Name,PREDEF_GRID_NAME,CCPP_PHYS_SUITE,EXTRN_MDL_NAME_ICS,EXTRN_MDL_NAME_LBCS,DATES (UTC),FCST_LEN_HRS (hrs),DT_ATMOS (s) | ||
| grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16,RRFS_CONUS_25km,GFS_v16,FV3GFS,FV3GFS,2019070100,6,40 | ||
| grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16,RRFS_CONUS_13km,GFS_v16,FV3GFS,FV3GFS,2019070100,6,45 | ||
| grid_SUBCONUS_Ind_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16,SUBCONUS_Ind_3km,GFS_v16,FV3GFS,FV3GFS,2019061518,6,40 | ||
| grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta,SUBCONUS_Ind_3km,RRFS_v1beta,HRRR,RAP,2020080100,6,40 | ||
| grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_HRRR,SUBCONUS_Ind_3km,HRRR,HRRR,RAP,2020081000,6,40 | ||
| grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0,SUBCONUS_Ind_3km,WoFS,HRRR,RAP,2020080100,6,40 | ||
| grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16,RRFS_CONUS_3km,GFS_v16,FV3GFS,FV3GFS,2019070100,6,36 | ||
| grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta,RRFS_CONUScompact_25km,RRFS_v1beta,HRRR,RAP,2020081000,3,40 | ||
| grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta,RRFS_CONUScompact_13km,RRFS_v1beta,HRRR,RAP,2020080100,6,45 | ||
| grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta,RRFS_CONUScompact_3km,RRFS_v1beta,HRRR,RAP,2020080100,6,40 | ||
| grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR,RRFS_CONUScompact_25km,HRRR,HRRR,RAP,2020081000,6,40 | ||
| grid_RRFS_CONUScompact_13km_ics_HRRR_lbcs_RAP_suite_HRRR,RRFS_CONUScompact_13km,HRRR,HRRR,RAP,2020081000,6,45 | ||
| grid_RRFS_CONUScompact_3km_ics_HRRR_lbcs_RAP_suite_HRRR,RRFS_CONUScompact_3km,HRRR,HRRR,RAP,2020081000,6,40 | ||
| grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta,RRFS_CONUS_25km,RRFS_v1beta,FV3GFS,FV3GFS,2019070100,6,40 | ||
| grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR,RRFS_CONUS_25km,HRRR,FV3GFS,FV3GFS,2019070100,6,40 | ||
| grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta,RRFS_CONUS_13km,RRFS_v1beta,FV3GFS,FV3GFS,2019070100,6,45 | ||
| grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR,RRFS_CONUS_13km,HRRR,FV3GFS,FV3GFS,2019070100,6,45 | ||
| grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_RRFS_v1beta,RRFS_CONUS_3km,RRFS_v1beta,FV3GFS,FV3GFS,2019070100,6,36 | ||
| grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_HRRR,RRFS_CONUS_3km,HRRR,FV3GFS,FV3GFS,2019070100,6,36 | ||
| community_ensemble_008mems,RRFS_CONUS_25km,FV3_GFS_2017_gfdlmp,FV3GFS,FV3GFS,"2019070100, 2019070112, 2019070200, 2019070212",6,40 | ||
| community_ensemble_2mems,RRFS_CONUS_25km,FV3_GFS_2017_gfdlmp,FV3GFS,FV3GFS,"2019070100, 2019070112, 2019070200, 2019070212",6,40 | ||
| deactivate_tasks,RRFS_CONUS_25km,FV3_GFS_v15p2,FV3GFS,FV3GFS,2019070100,6,40 | ||
| inline_post,RRFS_CONUS_25km,FV3_GFS_v15p2,FV3GFS,FV3GFS,2019070100,6,40 | ||
| MET_ensemble_verification,RRFS_CONUS_25km,FV3_GFS_v15p2,FV3GFS,FV3GFS,2019061500,6,40 | ||
| MET_verification,RRFS_CONUS_25km,FV3_GFS_v15p2,FV3GFS,FV3GFS,2019061500,6,40 | ||
| custom_ESGgrid,N/A,FV3_GFS_2017_gfdlmp_regional,FV3GFS,FV3GFS,2019070100,6,40 | ||
| custom_GFDLgrid,N/A,FV3_GFS_2017_gfdlmp,FV3GFS,FV3GFS,2019070100,6,100 | ||
| custom_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_FALSE,N/A,FV3_GFS_2017_gfdlmp,FV3GFS,FV3GFS,2019070100,6,100 | ||
| custom_GFDLgrid__GFDLgrid_USE_GFDLgrid_RES_IN_FILENAMES_eq_TRUE,N/A,FV3_GFS_2017_gfdlmp,FV3GFS,FV3GFS,2019070100,6,100 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,13 +148,9 @@ tasks; and the "FCST" type is used for the RUN_FCST_TN task. | |
| <workflow realtime="F" scheduler="&SCHED;" cyclethrottle="20"> | ||
| {# Double quotes are required inside the strftime! Expect an error from reading the template if using single quotes. #} | ||
| <cycledef group="at_start">{{ cdate_first_cycl.strftime("%M %H %d %m %Y *") }}</cycledef> | ||
| {% for c in cycl_hrs %} | ||
| <cycledef group="forecast"> | ||
| {%- set cdate_first=date_first_cycl ~ c ~ "00" -%} | ||
| {%- set cdate_last=date_last_cycl ~ c ~ "00" -%} | ||
| {{- cdate_first ~ " " ~ cdate_last ~ " " ~ cycl_freq -}} | ||
| {{- date_first_cycl ~ " " ~ date_last_cycl ~ " " ~ cycl_freq -}} | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The extra "minute" zeros here are added in the generate workflow script. |
||
| </cycledef> | ||
| {%- endfor %} | ||
|
|
||
| <log> | ||
| {%- if run_envir == "nco" %} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -601,7 +601,7 @@ if [ "${USE_FVCOM}" = "TRUE" ]; then | |
| #Format for fvcom_time: YYYY-MM-DDTHH:00:00.000000 | ||
| fvcom_exec_fn="fvcom_to_FV3" | ||
| fvcom_exec_fp="$EXECdir/${fvcom_exec_fn}" | ||
| fvcom_time="${DATE_FIRST_CYCL:0:4}-${DATE_FIRST_CYCL:4:2}-${DATE_FIRST_CYCL:6:2}T${CYCL_HRS[0]}:00:00.000000" | ||
| fvcom_time="${DATE_FIRST_CYCL:0:4}-${DATE_FIRST_CYCL:4:2}-${DATE_FIRST_CYCL:6:2}T${DATE_FIRST_CYCL:8:2}:00:00.000000" | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's unclear to me why this file name would be generated from the first cycle time of a workflow. Shouldn't it be of a given CDATE since the first cycle of an experiment is arbitrary, especially for real-time workflows?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dmwright526, since this is FVCOM-related, can you comment? |
||
| if [ ! -f "${fvcom_exec_fp}" ]; then | ||
| print_err_msg_exit "\ | ||
| The executable (fvcom_exec_fp) for processing FVCOM data onto FV3-LAM | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -929,7 +929,6 @@ they correspond to unique test names and rerun." | |
| "EXTRN_MDL_NAME_LBCS" \ | ||
| "DATE_FIRST_CYCL" \ | ||
| "DATE_LAST_CYCL" \ | ||
| "CYCL_HRS" \ | ||
| "INCR_CYCL_FREQ" \ | ||
| "FCST_LEN_HRS" \ | ||
| "LBC_SPEC_INTVL_HRS" \ | ||
|
|
@@ -1051,17 +1050,17 @@ configuration files of the primary WE2E tests... | |
| # to cover those cases. | ||
| # | ||
| # 2) The double quotes (which need to be escaped here, i.e. \") are needed | ||
| # so that for any experiment variables that are arrays, all the elements | ||
| # of the array are combined together and treated as a single element. | ||
| # If the experiment variable is CYCL_HRS (cycle hours) and is set to | ||
| # the array ("00" "12"), we want the value saved in the local array | ||
| # here to be a single element consisting of "00 12". Otherwise, "00" | ||
| # and "12" will be treated as separate elements, and more than one | ||
| # element would be added to the array (which would be incorrect here). | ||
| # so that for any experiment variables that are arrays, all the elements of | ||
| # the array are combined together and treated as a single element. For | ||
| # example, if a variable CYCL_HRS is set to the array ("00" "12"), we want | ||
| # the value saved in the local array here to be a single element consisting | ||
| # of "00 12". Otherwise, "00" and "12" will be treated as separate | ||
| # elements, and more than one element would be added to the array (which | ||
| # would be incorrect here). | ||
|
Comment on lines
1052
to
+1059
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With the removal of CYCL_HRS, does that mean none of these variables are arrays anymore?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there could still be arrays elsewhere. I am not sure though. I didn't remove the ability to set an array in the config file, though. |
||
| # | ||
| # 3) The single quote (which needs to be escaped here, i.e. \') is needed | ||
| # so that any numbers (e.g. a set of cycle hours such as "00 12") are | ||
| # treated as strings when the CSV file is opened in Google Sheets. | ||
| # so that any numbers (e.g. a set of cycle hours such as "00 12") are | ||
| # treated as strings when the CSV file is opened in Google Sheets. | ||
| # If this is not done, Google Sheets will remove leading zeros. | ||
| # | ||
| var_name_at="${var_name}[@]" | ||
|
|
@@ -1074,12 +1073,14 @@ configuration files of the primary WE2E tests... | |
| # Calculate the number of forecasts that will be launched by the current | ||
| # test. The "10#" forces bash to treat the following number as a decimal | ||
| # (not hexadecimal, etc). Note that INCR_CYCL_FREQ is in units of hours, | ||
| # so the factor of 24 is needed to convert the number of days to hours. | ||
| # | ||
| num_cycles_per_day=${#CYCL_HRS[@]} | ||
| num_days=$(( (${DATE_LAST_CYCL} - ${DATE_FIRST_CYCL} + 1)*24/10#${INCR_CYCL_FREQ} )) | ||
| num_cdates=$(( ${num_cycles_per_day}*${num_days} )) | ||
| nf=$(( ${num_cdates}*10#${NUM_ENS_MEMBERS} )) | ||
| # so the factor of 3600 is needed to convert the number of seconds to hours. | ||
| # | ||
| # Convert cycles to seconds | ||
| first=$(date --utc --date "${DATE_FIRST_CYCL:0:8} ${DATE_FIRST_CYCL:8:2}" +"%s") | ||
| last=$(date --utc --date "${DATE_LAST_CYCL:0:8} ${DATE_LAST_CYCL:8:2}" +"%s") | ||
| # Diff and convert seconds to number of cycles where freq is in | ||
| # hours | ||
| nf=$(( ($last - $first) / 3600 / 10#${INCR_CYCL_FREQ} )) | ||
|
christinaholtNOAA marked this conversation as resolved.
|
||
| # | ||
| # Save the number of forecasts launched by the current test in an | ||
| # appropriately named array. In the following, the single quote at the | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.