Skip to content

Fix setting of SRW_WE2E_COMPREHENSIVE_TESTS var#406

Merged
MichaelLueken merged 1 commit into
ufs-community:developfrom
jessemcfarland:bugfix/jenkinsfile
Oct 7, 2022
Merged

Fix setting of SRW_WE2E_COMPREHENSIVE_TESTS var#406
MichaelLueken merged 1 commit into
ufs-community:developfrom
jessemcfarland:bugfix/jenkinsfile

Conversation

@jessemcfarland
Copy link
Copy Markdown
Collaborator

@jessemcfarland jessemcfarland commented Oct 7, 2022

DESCRIPTION OF CHANGES:

The SRW_WE2E_COMPREHENSIVE_TESTS variable was incorrectly set by a sh block that proceeded the call to srw_test.sh. This issue was hidden because Jenkins sets the parameters to environment variables, which are accessible from sh blocks. However, the parameters do not seem to be set as environment variables the first time a multi-branch pipeline is initialized. This resulted in an unbound variable error when the SRW_WE2E_COMPREHENSIVE_TESTS variable was accessed by the srw_test.sh script. This update sets SRW_WE2E_COMPREHENSIVE_TESTS in the same sh block as the srw_test.sh script call, while ensuring the WORKSPACE variable isn't evaluated until the sh block.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

  • Work In Progress
  • bug
  • enhancement
  • documentation
  • release
  • high priority
  • run_ci
  • run_we2e_fundamental_tests
  • run_we2e_comprehensive_tests
  • Needs Cheyenne test
  • Needs Jet test
  • Needs Hera test
  • Needs Orion test
  • help wanted

The SRW_WE2E_COMPREHENSIVE_TESTS variable was incorrectly set by a sh
block that proceeded the call to srw_test.sh. This issue was hidden
because Jenkins sets the parameters to environment variables, which are
accessible from sh blocks. However, the parameters do not seem to be set
as environment variables the first time a multi-branch pipeline is
initialized. This resulted in an unbound variable error when the
SRW_WE2E_COMPREHENSIVE_TESTS variable was accessed by the srw_test.sh
script. This update sets SRW_WE2E_COMPREHENSIVE_TESTS in the same sh
block as the srw_test.sh script call, while ensuring the WORKSPACE
variable isn't evaluated until the sh block.
Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing so approving.

@MichaelLueken
Copy link
Copy Markdown
Collaborator

All of the tests successfully ran without first failing and requiring a re-run, so this update is ready to be merged.

@MichaelLueken MichaelLueken merged commit ed0e902 into ufs-community:develop Oct 7, 2022
@jessemcfarland jessemcfarland deleted the bugfix/jenkinsfile branch October 7, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants