Fix setting of SRW_WE2E_COMPREHENSIVE_TESTS var#406
Merged
MichaelLueken merged 1 commit intoOct 7, 2022
Conversation
The SRW_WE2E_COMPREHENSIVE_TESTS variable was incorrectly set by a sh block that proceeded the call to srw_test.sh. This issue was hidden because Jenkins sets the parameters to environment variables, which are accessible from sh blocks. However, the parameters do not seem to be set as environment variables the first time a multi-branch pipeline is initialized. This resulted in an unbound variable error when the SRW_WE2E_COMPREHENSIVE_TESTS variable was accessed by the srw_test.sh script. This update sets SRW_WE2E_COMPREHENSIVE_TESTS in the same sh block as the srw_test.sh script call, while ensuring the WORKSPACE variable isn't evaluated until the sh block.
MichaelLueken
approved these changes
Oct 7, 2022
danielabdi-noaa
approved these changes
Oct 7, 2022
Collaborator
danielabdi-noaa
left a comment
There was a problem hiding this comment.
Tests are passing so approving.
Collaborator
|
All of the tests successfully ran without first failing and requiring a re-run, so this update is ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
The SRW_WE2E_COMPREHENSIVE_TESTS variable was incorrectly set by a sh block that proceeded the call to srw_test.sh. This issue was hidden because Jenkins sets the parameters to environment variables, which are accessible from sh blocks. However, the parameters do not seem to be set as environment variables the first time a multi-branch pipeline is initialized. This resulted in an unbound variable error when the SRW_WE2E_COMPREHENSIVE_TESTS variable was accessed by the srw_test.sh script. This update sets SRW_WE2E_COMPREHENSIVE_TESTS in the same sh block as the srw_test.sh script call, while ensuring the WORKSPACE variable isn't evaluated until the sh block.
Type of change
TESTS CONDUCTED:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR: