Port SRW App to WCOSS2

[chan-hoo]

DESCRIPTION OF CHANGES:

• Port the UFS SRW App to WCOSS2 (Cactus / Dogwood).

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

TESTS CONDUCTED:

• WE2E tests on WCOSS2, Hera, and Orion:
  MET_verification
  community_ensemble_2mems_stoch
  grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp_regional
  grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
  grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR
  grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km
  grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta
  nco_grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16
  nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR

• hera.intel

• orion.intel

• cheyenne.intel

• cheyenne.gnu

• gaea.intel

• jet.intel

• wcoss2.intel

• NOAA Cloud (indicate which platform)

• Jenkins

• fundamental test suite

• comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes issue mentioned in #365

CHECKLIST

• My code follows the style guidelines in the Contributor's Guide
• I have performed a self-review of my own code using the Code Reviewer's Guide
• I have commented my code, particularly in hard-to-understand areas
• My changes need updates to the documentation. I have made corresponding changes to the documentation
• My changes do not require updates to the documentation (explain).
• My changes generate no new warnings
• New and existing tests pass with my changes
• Any dependent changes have been merged and published

CONTRIBUTORS:

@BenjaminBlake-NOAA

[chan-hoo]

@BenjaminBlake-NOAA @RatkoVasic-NOAA @MatthewPyle-NOAA @ShunLiu-NOAA @hu5970: Can you review and test this PR on Cactus?

[BenjaminBlake-NOAA]

@chan-hoo Sure, I will test it on Cactus today. Thanks for putting this together!

[MatthewPyle-NOAA]

Awesome on getting this together so quickly! One quick question - what required the elimination of the module purge lines on Hera and Orion?

[chan-hoo]

@MatthewPyle-NOAA, as far as I know, 'module purge' does not work inside a module file.

[danielabdi-noaa]

That looks good to me! I've left some minor suggestions

[ShunLiu-NOAA]

Thank you, Chan-Hoo.

Have you tested the workflow with CONUS-3km and the new North America 3km grid?

Shun

[chan-hoo]

@ShunLiu-NOAA, I tested it with CONUS 3km (grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km), but I didn't test NA 3km. I'll run a WE2E test for NA 3km.

[ShunLiu-NOAA]

Chan-Hoo, If you can test C3359 and C3463 grid, it will be great. I assume conus-3km is C3359 not C3357. They are the grid used for RRFS-A-CONUS and RRFS-A-NA. Thank you. Shun

…

On Fri, Oct 7, 2022 at 9:17 AM Chan-Hoo.Jeon-NOAA ***@***.***> wrote: @ShunLiu-NOAA <https://github.com/ShunLiu-NOAA>, I tested it with CONUS 3km (grid_RRFS_CONUS_3km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15_thompson_mynn_lam3km), but I didn't test NA 3km. I'll run a WE2E test for NA 3km. — Reply to this email directly, view it on GitHub <#405 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACD5GZYAWXNLJYFRKKB2SWTWCAPH7ANCNFSM6AAAAAAQ7QZRRA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[chan-hoo]

@ShunLiu-NOAA, The RRFS_CONUS_3km domain, used in WE2E, is C3359.

[MichaelLueken]

@chan-hoo Please update your feature/port_wcoss2 branch to the latest in the official repository. Several PRs were merged yesterday to add Jenkins testing functionality to the SRW. Once this PR has received at least one approval from a code manager, the run_we2e_fundamental_test label will be added to kick off the Jenkins automated testing on all level 1 machines. Once the Jenkins build and testing completes successfully, then this PR will be able to be merged.

[chan-hoo]

@MichaelLueken, Once a reviewer approves this PR, will the run_we2e_fundamental_test label be added automatically? or should one of the code reviewers add the label manually?

[MichaelLueken]

@chan-hoo Once a reviewer has approved this PR, then a code reviewer will need to add the label manually.

[chan-hoo]

I got it! I'll add the label unless the reviewers do.

[BenjaminBlake-NOAA]

I was able to build all components of the SRW app on Cactus and run the workflow successfully for the RRFS_CONUS_3km grid. Since the WE2E tests passed for Chan-Hoo, I approve these changes.

[chan-hoo]

@MichaelLueken, the build failure on Gaea is not caused by this PR. I think @danielabdi-noaa opened a PR for this (#407).

[MichaelLueken]

@chan-hoo You are correct. There was an update on Gaea, which is causing the failure on Jenkins for Gaea. I will be moving forward with your changes once the rest of the tests pass.

[MatthewPyle-NOAA]

Just realizing that my comment about inclusion of modules in run.ver was in limbo. Submitting the comment now.

[MichaelLueken]

@chan-hoo The Jenkins tests have completed. Once you have addressed @MatthewPyle-NOAA and @danielabdi-noaa issue with using the versions in the run.ver file, I will be able to approve and commit this update.

[danielabdi-noaa]

Looks good to me!