Skip to content

[develop] Fix the inline-post issue when WRITE_DOPOST is 'true'#372

Merged
chan-hoo merged 1 commit into
ufs-community:developfrom
chan-hoo:bugfix/inline-post
Sep 23, 2022
Merged

[develop] Fix the inline-post issue when WRITE_DOPOST is 'true'#372
chan-hoo merged 1 commit into
ufs-community:developfrom
chan-hoo:bugfix/inline-post

Conversation

@chan-hoo
Copy link
Copy Markdown
Collaborator

DESCRIPTION OF CHANGES:

  • Add the 'itag' namelist file for inline-post to 'run_dir' in the 'exregional_run_fcst' script.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • WE2E tests:
    inline_post
    nco_inline_post
    grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16

  • hera.intel

  • orion.intel

  • cheyenne.intel

  • cheyenne.gnu

  • gaea.intel

  • jet.intel

  • wcoss2.intel

  • NOAA Cloud (indicate which platform)

  • Jenkins

  • fundamental test suite

  • comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes issue mentioned in #371

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Copy Markdown
Collaborator

@danielabdi-noaa danielabdi-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a critical bug fix so approving.

@chan-hoo chan-hoo merged commit 63264bf into ufs-community:develop Sep 23, 2022
@chan-hoo chan-hoo deleted the bugfix/inline-post branch September 23, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants