[release/public-v2] Cleaning up modules and separating hpc-stack and spack-stack for srw_common#308
Merged
mark-a-potts merged 6 commits intoJun 16, 2022
Conversation
mark-a-potts
requested review from
BenjaminBlake-NOAA,
EdwardSnyder-NOAA,
JeffBeck-NOAA,
RatkoVasic-NOAA,
chan-hoo,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
dmwright526,
gsketefian,
gspetro-NOAA,
jkbk2004,
mkavulich,
natalie-perlin,
panll,
willmayfield and
ywangwof
as code owners
Contributor
Author
|
The one ci check that failed was on Orion due to an inaccessible v2p0 directory. I have asked Mike Kavulich to fix the permissions, which will fix that issue. |
EdwardSnyder-NOAA
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the modules and returns them to straight "module load" commands after issues were uncovered using "module load-any" on Cheyenne and Azure.
This also adds in the FV3_WoFS_v0 suite to the src/CMakeLists.txt where it was missing.